Replaced broken sed command (on macs) with ed alternative. #836
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #790
Fixed the broken
sed
command with aned
alternative. Spent some time trying to get an alternativesed
command to work but I was not able to find one.The new
ed
command finds theCONNECT_VERSION
line, moves to the next line and changes the whole line with the new content, then stops processing changes, saves and quits.I noticed that all blocks for each product use the same pattern, I can update the rest when the changes are reviewed / approved.
I also noticed that this notation seems to break syntax highlighting on VSCode. I have an alternative
awk
implementation that does not have that issue (it requires a file swap so I favoreded
since it does the change in place):