Upgrade Workbench JupyterLab to 4.x #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianpittwood
requested review from
cm421,
melissa-barca,
bschwedler and
costrouc
as code owners
melissa-barca
approved these changes
Oct 2, 2024
bjfletcher
reviewed
Oct 11, 2024
| && ln -s /opt/python/jupyter/bin/jupyter /usr/local/bin/jupyter \ | ||
| && /opt/python/jupyter/bin/python -m pip install ipykernel \ | ||
| && /opt/python/jupyter/bin/python -m ipykernel install --name py${PYTHON_VERSION} --display-name "Python ${PYTHON_VERSION}" \ | ||
| && /opt/python/jupyter/bin/python -m ipykernel install --name py${PYTHON_VERSION_ALT} --display-name "Python ${PYTHON_VERSION_ALT}" \ |
There was a problem hiding this comment.
Hi @ianpittwood, JupyterLab has stopped working for us.
If I run:
docker run -it --platform linux/amd64 rstudio/r-session-complete:ubuntu2204-2024.09.0 bashI see that the two python -m ipykernel install lines in your Dockerfile produce the following kernel configurations:
/usr/local/share/jupyter/kernels/py3.11.10/kernel.json
{
...
"/opt/python/jupyter/bin/python",
...
"display_name": "Python 3.11.10",
...
}
/usr/local/share/jupyter/kernels/py3.12.6/kernel.json
{
...
"/opt/python/jupyter/bin/python",
...
"display_name": "Python 3.12.6",
...
}
Note how the paths for both 3.11 and 3.12 point to the same one Python binary, which is 3.12.
It'd be great if this is fixed because 3.12 doesn't work with most ML libraries/models.
There was a problem hiding this comment.
Thanks for pointing this out. This should fix the issue: #855
There was a problem hiding this comment.
Thanks @ianpittwood . Sorry to be a pain, but !pip install <pkg> has been broken too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Jupyterlab to 4.x since 3.x has been deprecated