Feature/workbench session #874
Conversation
zachhannum
force-pushed
the
feature/workbench-session
branch
from
762bc58 to
5d9c081
Compare
zachhannum
force-pushed
the
feature/workbench-session
branch
from
31b0912 to
ec39cda
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
|
||
| ### Install TinyTeX using Quarto ### | ||
| RUN $SCRIPTS_DIR/install_quarto.sh --install-tinytex --add-path-tinytex | ||
| ENV PATH="/opt/python/jupyter/bin:/opt/python/bin:/usr/lib/rstudio-server/bin/quarto/bin:${PATH}" |
There was a problem hiding this comment.
Does the init container install tinytex now?
There was a problem hiding this comment.
It does not. The discussion happened in #workbench-dev so I can't link it here, but I'll re-post my notes here:
I don't think the TinyTex installation works at all on the existing r-session-complete images:
zach.hannum@session-0da293c9ab5a7f73c50c8-zachhannum---vs-code-sessionqxv4f:~$ quarto tools
[✓] Inspecting tools
Tool Status Installed Latest
chromium Not installed --- 869685
tinytex Not installed --- v2024.11
From root:
root@session-0da293c9ab5a7f73c50c8-zachhannum---vs-code-sessionqxv4f:~# which tlmgr
/usr/local/bin/tlmgr
root@session-0da293c9ab5a7f73c50c8-zachhannum---vs-code-sessionqxv4f:~# ls -al /usr/local/bin/tlmgr
lrwxrwxrwx 1 root root 37 Nov 21 12:18 /usr/local/bin/tlmgr -> /root/.TinyTeX/bin/x86_64-linux/tlmgr
zach.hannum@session-0da293c9ab5a7f73c50c8-zachhannum---vs-code-sessionqxv4f:~$ echo $PATH
/usr/lib/rstudio-server/bin/pwb-code-server/bin/remote-cli:/opt/python/jupyter/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
Back in the session:
zach.hannum@session-0da293c9ab5a7f73c50c8-zachhannum---vs-code-sessionqxv4f:~$ stat /root/.TinyTeX/bin/x86_64-linux/tlmgr
stat: cannot statx '/root/.TinyTeX/bin/x86_64-linux/tlmgr': Permission denied
Okay, so it's on the PATH but we don't actually have the correct permissions to use it.
tinytex doesn't really seem to want to behave as a system dependency, it's installer sticks it in the user's home directory by default.
IMO we should just leave tinytex off the base installation and let users install it to their home directory via quarto if they need it.
Co-authored-by: Skye Turriff <turriff.skye@gmail.com>
| @@ -185,6 +185,10 @@ variable WORKBENCH_BUILD_MATRIX { | |||
| } | |||
| } | |||
|
|
|||
| variable WORKBENCH_SESSION_MATRIX { | |||
| default = PRO_BUILD_MATRIX | |||
There was a problem hiding this comment.
Just curious, what's the reasoning behind inheriting all the base image builds?
There was a problem hiding this comment.
Similar to content-pro, I didn't see a reason to not offer a few different combinations of R and Python versions for images. I'm happy to be overridden on that decision if it doesn't make sense, though.
There was a problem hiding this comment.
OK, I can understand that. I think this is fine for now. It's something we can take into account for future planning.
Adds a new target for
rstudio/workbench-session, which is a docker image that will eventually replacer-session-completefor use with the new session init container feature.It is essentially a copy/paste of r-session-complete with two major differences: