Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-bake.yaml #878

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Update build-bake.yaml #878

merged 1 commit into from
Nov 27, 2024

Conversation

skyeturriff
Copy link
Contributor

Removal of release workbench-session-init job from GitHub actions for the merge to main.

Copy link
Contributor

@zachhannum zachhannum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of deleting the entire job, I would just add:

if: false

To prevent the job from running under all conditions. Then we can remove that line when we want to enable it again.

https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idif

@skyeturriff
Copy link
Contributor Author

Ah, thank you! I should have done some research first 🥹 I can make the changes this aft

temp removal of workbench-session-init from github actions release build
@bschwedler
Copy link
Contributor

@skyeturriff I amended the commit and can shepherd this through the PRs today.

Copy link
Contributor

@zachhannum zachhannum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Skye for tackling this, and thanks Ben for herding these changes through!

@bschwedler bschwedler merged commit 1d62002 into dev Nov 27, 2024
41 of 42 checks passed
@bschwedler bschwedler deleted the skyeturriff-patch-1 branch November 27, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants