Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable workbench-session-init release target #880

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

skyeturriff
Copy link
Contributor

Addresses https://github.com/rstudio/rstudio-pro/issues/7038

This should be merged in after/at the same time as RSW_VERSION is updated to 2024.12.

Removes the WORKBENCH_SESSION_INIT_VERSION var that was being used as a temporary workaround to grab the daily version, replacing it with WORKBENCH_VERSION. Also re-enables the workbench-session-init release target.

@skyeturriff
Copy link
Contributor Author

The workbench-session-init check will fail until the workbench version is bumped

… enable-workbench-session-init-release-build
@melissa-barca melissa-barca marked this pull request as ready for review December 17, 2024 18:21
Copy link
Contributor

@melissa-barca melissa-barca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@zachhannum zachhannum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melissa-barca melissa-barca merged commit c746672 into dev Dec 17, 2024
40 of 42 checks passed
@melissa-barca melissa-barca deleted the enable-workbench-session-init-release-build branch December 17, 2024 20:17
@melissa-barca melissa-barca mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants