Fix for issue #257 #328
Open
Fix for issue #257 #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please add fix upstream! |
gagan0123
reviewed
Jun 13, 2024
| $response = wp_remote_get( $url ); | ||
| $request_args = array( | ||
| 'blocking' => false, | ||
| 'sslverify' => false |
There was a problem hiding this comment.
This can be a security issue and sslverify should not be set to false at all unless you're testing things locally.
| @@ -461,7 +461,11 @@ protected function do_remote_get( $url ) { | |||
| */ | |||
| do_action( 'rt_nginx_helper_before_remote_purge_url', $url ); | |||
|
|
|||
| $response = wp_remote_get( $url ); | |||
| $request_args = array( | |||
| 'blocking' => false, | |||
There was a problem hiding this comment.
Doing this will break the logging functionality and any actions that other plugins are performing on the hook rt_nginx_helper_after_remote_purge_url since a non blocking request initially starts with status 0, meaning the request is still processing, instead of actual status code like 200 or 404.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#257