Merge pull request #1371 from rtMediaWP/develop

Version update v4.5.7

README.md

@@ -7,7 +7,7 @@
 # rtMedia for WordPress, BuddyPress and bbPress #
 
 
-* **Contributors:** [rtcamp](http://profiles.wordpress.org/rtcamp), [mangeshp](http://profiles.wordpress.org/mangeshp), [sanket.parmar](http://profiles.wordpress.org/sanket.parmar), [pranalipatel](http://profiles.wordpress.org/pranalipatel), [jignesh.nakrani](http://profiles.wordpress.org/jignesh.nakrani), [manishsongirkar36](http://profiles.wordpress.org/manishsongirkar36), [kiranpotphode](http://profiles.wordpress.org/kiranpotphode), [yahil](http://profiles.wordpress.org/yahil), [1naveengiri](http://profiles.wordpress.org/1naveengiri), [bhargavbhandari90](http://profiles.wordpress.org/bhargavbhandari90), [deepak1191](http://profiles.wordpress.org/deepak1191), [rittesh.patel](http://profiles.wordpress.org/rittesh.patel), [sagarjadhav](http://profiles.wordpress.org/sagarjadhav), [pushpak.pop](http://profiles.wordpress.org/pushpak.pop), [faishal](http://profiles.wordpress.org/faishal), [desaiuditd](http://profiles.wordpress.org/desaiuditd), [rahul286](http://profiles.wordpress.org/rahul286), [JoshuaAbenazer](http://profiles.wordpress.org/JoshuaAbenazer), [gagan0123](http://profiles.wordpress.org/gagan0123), [saurabhshukla](http://profiles.wordpress.org/saurabhshukla), [nitun.lanjewar](http://profiles.wordpress.org/nitun.lanjewar), [umesh.nevase](http://profiles.wordpress.org/umesh.nevase), [suhasgirgaonkar](http://profiles.wordpress.org/suhasgirgaonkar), [neerukoul](http://profiles.wordpress.org/neerukoul), [hrishiv90](http://profiles.wordpress.org/hrishiv90), [kanakiyajay](http://profiles.wordpress.org/kanakiyajay), [jarretc](http://profiles.wordpress.org/jarretc), [tobiaskluge](http://profiles.wordpress.org/tobiaskluge), [rafaelfunchal](http://profiles.wordpress.org/rafaelfunchal), [UmeshSingla](http://profiles.wordpress.org/UmeshSingla), [mehulkaklotar](http://profiles.wordpress.org/mehulkaklotar), [tannermirabel](http://profiles.wordpress.org/tannermirabel), [kishores](http://profiles.wordpress.org/kishores), [chandrapatel](http://profiles.wordpress.org/chandrapatel), [rahul3883](http://profiles.wordpress.org/rahul3883/), [nomnom99](http://profiles.wordpress.org/nomnom99), [sayanchakraborty](https://profiles.wordpress.org/sayanchakraborty), [milindmore22](https://profiles.wordpress.org/milindmore22), [thrijith](https://profiles.wordpress.org/thrijith), [abhijitrakas](https://profiles.wordpress.org/abhijitrakas), [sid177](https://profiles.wordpress.org/sid177), [montu3366](https://profiles.wordpress.org/montu3366), [jashwini](https://profiles.wordpress.org/jashwini), [juhise](https://profiles.wordpress.org/juhise), [ravatparmar](https://profiles.wordpress.org/ravatparmar), [dharmin16](https://profiles.wordpress.org/dharmin16), [malavvasita](https://profiles.wordpress.org/malavvasita), [pooja1210](https://profiles.wordpress.org/pooja1210), [krupajnanda](https://profiles.wordpress.org/krupajnanda)
+* **Contributors:** [rtcamp](http://profiles.wordpress.org/rtcamp), [mangeshp](http://profiles.wordpress.org/mangeshp), [sanket.parmar](http://profiles.wordpress.org/sanket.parmar), [pranalipatel](http://profiles.wordpress.org/pranalipatel), [jignesh.nakrani](http://profiles.wordpress.org/jignesh.nakrani), [manishsongirkar36](http://profiles.wordpress.org/manishsongirkar36), [kiranpotphode](http://profiles.wordpress.org/kiranpotphode), [yahil](http://profiles.wordpress.org/yahil), [1naveengiri](http://profiles.wordpress.org/1naveengiri), [bhargavbhandari90](http://profiles.wordpress.org/bhargavbhandari90), [deepak1191](http://profiles.wordpress.org/deepak1191), [rittesh.patel](http://profiles.wordpress.org/rittesh.patel), [sagarjadhav](http://profiles.wordpress.org/sagarjadhav), [pushpak.pop](http://profiles.wordpress.org/pushpak.pop), [faishal](http://profiles.wordpress.org/faishal), [desaiuditd](http://profiles.wordpress.org/desaiuditd), [rahul286](http://profiles.wordpress.org/rahul286), [JoshuaAbenazer](http://profiles.wordpress.org/JoshuaAbenazer), [gagan0123](http://profiles.wordpress.org/gagan0123), [saurabhshukla](http://profiles.wordpress.org/saurabhshukla), [nitun.lanjewar](http://profiles.wordpress.org/nitun.lanjewar), [umesh.nevase](http://profiles.wordpress.org/umesh.nevase), [suhasgirgaonkar](http://profiles.wordpress.org/suhasgirgaonkar), [neerukoul](http://profiles.wordpress.org/neerukoul), [hrishiv90](http://profiles.wordpress.org/hrishiv90), [kanakiyajay](http://profiles.wordpress.org/kanakiyajay), [jarretc](http://profiles.wordpress.org/jarretc), [tobiaskluge](http://profiles.wordpress.org/tobiaskluge), [rafaelfunchal](http://profiles.wordpress.org/rafaelfunchal), [UmeshSingla](http://profiles.wordpress.org/UmeshSingla), [mehulkaklotar](http://profiles.wordpress.org/mehulkaklotar), [tannermirabel](http://profiles.wordpress.org/tannermirabel), [kishores](http://profiles.wordpress.org/kishores), [chandrapatel](http://profiles.wordpress.org/chandrapatel), [rahul3883](http://profiles.wordpress.org/rahul3883/), [nomnom99](http://profiles.wordpress.org/nomnom99), [sayanchakraborty](https://profiles.wordpress.org/sayanchakraborty), [milindmore22](https://profiles.wordpress.org/milindmore22), [thrijith](https://profiles.wordpress.org/thrijith), [abhijitrakas](https://profiles.wordpress.org/abhijitrakas), [sid177](https://profiles.wordpress.org/sid177), [montu3366](https://profiles.wordpress.org/montu3366), [jashwini](https://profiles.wordpress.org/jashwini), [juhise](https://profiles.wordpress.org/juhise), [ravatparmar](https://profiles.wordpress.org/ravatparmar), [dharmin16](https://profiles.wordpress.org/dharmin16), [malavvasita](https://profiles.wordpress.org/malavvasita), [pooja1210](https://profiles.wordpress.org/pooja1210), [krupajnanda](https://profiles.wordpress.org/krupajnanda), [kanumalivad](https://profiles.wordpress.org/kanumalivad), [surajkumarsingh](https://profiles.wordpress.org/surajkumarsingh)
 
 
 * **License:** [GPL v2 or later]( http://www.gnu.org/licenses/gpl-2.0.html)
@@ -50,9 +50,7 @@ https://www.youtube.com/watch?v=dJrykKQGDcs
 
 rtMedia has 3 premium solutions to take care of audio/video conversion.
 
- 1. **[Audio/Video Transcoding Service](https://wordpress.org/plugins/transcoder/ "Audio/Video Transcoding Service")** - If free plan is not enough for you, there is monthly subscription service also. Easiest to setup.
- 2. **[FFMPEG-Addon](https://rtmedia.io/products/rtmedia-ffmpeg-addon/?utm_source####readme&utm_medium####plugin&utm_campaign####buddypress-media "rtMedia FFMPEG Addon")** - Requires FFMPEG & Media-Node installed on a VPS/Dedicated server.
- 3. **[Kaltura-Addon](https://rtmedia.io/products/rtmedia-kaltura-add-on/?utm_source####readme&utm_medium####plugin&utm_campaign####buddypress-media "rtMedia Kaltura Addon for Kaltura.com/Kaltura-CE/Kaltura On-Prem version")** - Requires a Kaltura.com account or Kaltura-CE or Kaltura-on-Prem server.
+ - **[Audio/Video Transcoding Service](https://wordpress.org/plugins/transcoder/ "Audio/Video Transcoding Service")** - If free plan is not enough for you, there is monthly subscription service also. Easiest to setup.
 
 #### rtMedia Premium Addons ####
 
@@ -147,7 +145,27 @@ https://www.youtube.com/watch?v=dJrykKQGDcs
 
 ## Changelog ##
 
-### 4.5.6 [February 14, 2019] ###
+### 4.5.7 [June 12, 2019] ###
+
+* NEW
+    * Add new filter to remove the media upload button from the activity [Doc](https://rtmedia.io/docs/developers/hooks/rtmedia-enable-activity-media-upload/)
+    * Add new filter to change the order of the media and text on the activity page [Doc](https://rtmedia.io/docs/developers/hooks/rtmedia-activity-content-html/)
+
+* FIXED
+    * Duplicate media comment issue on Activity page
+    * Add title attribute for Media Likes
+    * Improve UI of Media Page title
+    * Issue of entering text in text area when Direct Upload and Upload terms enabled together
+    * UI of pagination button height and text field
+    * Export/Import button issue in Firefox browser
+    * Issue of direct upload and media was not opening in lightbox with TwentySeventeen theme v2.1 
+    * Empty space issue for generated activity when media is uploaded without adding text 
+    * Other Errors, Warnings and notices
+    * Group Activity media are not shown in Group Media tab with BuddyPress Nouveau Template
+    * User’s name autosuggestion
+    * Issue with multiple file upload from activity with non admin user account
+
+### 4.5.6 [February 18, 2019] ###
 
 * FIXED
 
@@ -1047,7 +1065,7 @@ https://www.youtube.com/watch?v=dJrykKQGDcs
 * Admin UI bug fixes
 
 #### 3.5.2 ####
-* Updated dutch translation, thanks to [carry2web] (http://profiles.wordpress.org/carry2web)
+* Updated dutch translation, thanks to [carry2web](http://profiles.wordpress.org/carry2web)
 * Enable / disable media per group
 * User can specify media type to be upload in uploader shortcode
 * Show content of single album using gallery shortcode
@@ -1609,7 +1627,7 @@ Now upload media in comment & fixed rtMedia shortcode pagination along with seve
 
 rtMedia includes [full translation support](https://rtmedia.io/docs/translations/?utm_source####readme&utm_medium####plugin&utm_campaign####buddypress-media). Head over to the [translation project](https://rtmedia.io/translate/projects/rtmedia/?utm_source####readme&utm_medium####plugin&utm_campaign####buddypress-media) to contribute your translations. If you don't see the language of your choice, let us know in the support forum, we'll add it.
 
-* [Dutch](https://rtmedia.io/translate/projects/rtmedia/nl/default) translation by [carry2web] (http://profiles.wordpress.org/carry2web)
+* [Dutch](https://rtmedia.io/translate/projects/rtmedia/nl/default) translation by [carry2web](http://profiles.wordpress.org/carry2web)
 * [Italian](https://rtmedia.io/translate/projects/rtmedia/it/default) translation by [Paolo]
 * [Dutch](https://rtmedia.io/translate/projects/rtmedia/nl/default) translation by [rjpj](http://profiles.wordpress.org/rjpj)
 * [Polish](https://rtmedia.io/translate/projects/rtmedia/pl/default) translation by [Polski_Ziom](http://profiles.wordpress.org/polski_ziom)

app/admin/RTMediaAdmin.php

@@ -1840,7 +1840,7 @@ class="clearfix <?php echo esc_attr( $tab_position_class ); ?> rtm-admin-tab-con
 						// tab icon
 						$icon = '';
 						if ( isset( $tab['icon'] ) && ! empty( $tab['icon'] ) ) {
-							$icon = '<i class="' . esc_attr( $tab['icon'] ) . ' dashicons rtmicon"></i>';
+							$icon = '<i class="' . esc_attr( $tab['icon'] ) . ' dashicons"></i>';
 						}
 						?>
 						<li class="<?php echo esc_attr( $active_class ) ?> <?php echo esc_attr( $error_class ) ?>">

app/admin/RTMediaFormHandler.php

@@ -881,7 +881,7 @@ public static function types_content() {
 								if ( 'other' !== $key ) {
 									?>
 									<span class="rtm-tooltip rtm-extensions">
-										<i class="dashicons dashicons-info rtmicon"></i>
+										<i class="dashicons dashicons-info"></i>
 										<span class="rtm-tip">
 											<strong><?php echo esc_html__( 'File Extensions', 'buddypress-media' ); ?></strong><br/>
 											<hr/>
@@ -1568,7 +1568,7 @@ public static function render_option_content( $option ) {
 						<span
 							class="rtm-field-wrap"><?php call_user_func( $option['callback'], $option['args'] ); ?></span>
 						<span class="rtm-tooltip">
-							<i class="dashicons dashicons-info rtmicon"></i>
+							<i class="dashicons dashicons-info"></i>
 							<span class="rtm-tip">
 								<?php echo wp_kses( ( isset( $option['args']['desc'] ) ) ? $option['args']['desc'] : 'NA', array(
 									'a' => array(

app/assets/admin/js/settings.js

@@ -965,6 +965,7 @@ jQuery( document ).ready( function ( $ ) {
 			var downloadAnchorNode = document.createElement( 'a' );
 			downloadAnchorNode.setAttribute( 'href', dataStr );
 			downloadAnchorNode.setAttribute( 'download', 'rtm-settings.json' );
+			jQuery( 'body' ).append( downloadAnchorNode );
 			downloadAnchorNode.click();
 			downloadAnchorNode.remove();
 		} );

app/assets/css/rtmedia.css

@@ -343,6 +343,9 @@ button#rtmedia-add-media-button-post-update .dashicons {
 #buddypress a.rtm-button-back {
   padding: 3px 10px;
 }
+#buddypress div.rtmedia-page-no.rtm-page-number a.rtmedia-page-link.button {
+  padding: 5px 10px;
+}
 
 .rtmedia_next_prev {
   padding: 0 10px;
@@ -359,6 +362,10 @@ button#rtmedia-add-media-button-post-update .dashicons {
 .rtm-page-number .rtmedia-page-link {
   float: left;
 }
+.rtm-page-number .rtm-go-to-num,
+.rtm-page-number .rtmedia-page-link {
+  line-height: 1.5;
+}
 
 .rtm-pagination {
   background: transparent;
@@ -398,7 +405,7 @@ button#rtmedia-add-media-button-post-update .dashicons {
 #rtmedia_go_to_num {
   font-size: 16px;
   margin: 0 5px;
-  padding: 4px 5px;
+  padding: 3px 5px;
   width: 80px;
 }
 
@@ -1160,7 +1167,7 @@ img.mfp-img {
 /*
 * popup autocomplete
  */
-#atwho-container #atwho-ground-comment_content .atwho-view {
+.atwho-container #atwho-ground-comment_content .atwho-view {
   z-index: 2147483647;
 }
 
@@ -1260,10 +1267,6 @@ img.mfp-img {
   padding: 0 4px 0 0;
 }
 
-#buddypress #rtm-media-options-list .rtm-options form button {
-  font-size: small;
-}
-
 #buddypress #rtm-media-options-list .rtm-options .button {
   background: transparent;
   border: 0 none;
@@ -1274,13 +1277,18 @@ img.mfp-img {
   font-weight: normal;
   line-height: 24px;
   padding: 0 6px;
-  text-shadow: 0 0 0;
   text-transform: none;
 }
 #buddypress #rtm-media-options-list .rtm-options .rtmedia-delete-favlist {
   color: #FFFFFF;
   padding: 0;
 }
+#buddypress #rtm-media-options-list .rtm-options form button {
+  font-size: 14px;
+}
+#buddypress #rtm-media-options-list .rtm-options i {
+  line-height: 1.7;
+}
 
 .rtm-options.rtm-options {
   background: #666666;
@@ -2596,6 +2604,10 @@ body div.bp_members.bp_member .entry-content {
   display: none;
 }
 
+h2.rtm-gallery-title {
+  margin: 10px 0;
+}
+
 .rtmedia-uploader .drag-drop {
   border: 4px dashed #DDD;
   text-align: center;

app/assets/css/sass/_media-tab.scss

@@ -11,6 +11,10 @@ body {
 	display: none;
 }
 
+h2.rtm-gallery-title  {
+	margin: 10px 0;
+}
+
 .rtmedia-uploader {
 	.drag-drop {
 		border: 4px dashed #DDD;

app/assets/css/sass/_popup.scss

@@ -1,7 +1,7 @@
 /*
 * popup autocomplete
  */
-#atwho-container {
+.atwho-container {
 	#atwho-ground-comment_content {
 		.atwho-view {
 			z-index: 2147483647;
@@ -124,14 +124,6 @@
 	}
 }
 
-#buddypress #rtm-media-options-list {
-	.rtm-options {
-		form button {
-			font-size: small;
-		}
-	}
-}
-
 #buddypress #rtm-media-options-list {
 	.rtm-options {
 		.button {
@@ -144,14 +136,21 @@
 			font-weight: normal;
 			line-height: 24px;
 			padding: 0 6px;
-			text-shadow: 0 0 0;
 			text-transform: none;
 		}
 
 		.rtmedia-delete-favlist {
 			color: $white;
 			padding: 0;
 		}
+
+		form button {
+			font-size: 14px;
+		}
+
+		i {
+			line-height: 1.7;
+		}
 	}
 }
 

app/assets/css/sass/_rtm.scss

@@ -200,9 +200,14 @@ button#rtmedia-add-media-button-post-update {
 }
 
 #buddypress {
-		a.rtm-button-back{
-			padding: 3px 10px;
+	a.rtm-button-back{
+		padding: 3px 10px;
+	}
+	div.rtmedia-page-no.rtm-page-number {
+		a.rtmedia-page-link.button {
+			padding: 5px 10px;
 		}
+	}
 }
 
 // Pagination
@@ -222,6 +227,10 @@ button#rtmedia-add-media-button-post-update {
 	.rtmedia-page-link {
 		float: left;
 	}
+	.rtm-go-to-num,
+	.rtmedia-page-link {
+		line-height: 1.5;
+	}
 }
 
 .rtm-pagination {
@@ -264,12 +273,13 @@ button#rtmedia-add-media-button-post-update {
 		padding: 0;
 		width: auto;
 	}
+
 }
 
 #rtmedia_go_to_num {
 	font-size: 16px;
 	margin: 0 5px;
-	padding: 4px 5px;
+	padding: 3px 5px;
 	width: 80px;
 }