Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Add tests for CoreHeading block #10

Merged
merged 14 commits into from
Sep 26, 2024
Merged

tests: Add tests for CoreHeading block #10

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0ca59a1
feat: Add CoreHeadingTest
ashutoshgautams Sep 14, 2024
039a0d1
chore: refactor CoreHeadingTest
justlevine Sep 15, 2024
92e7ae6
chore: cleanup
justlevine Sep 15, 2024
cdec9ee
feat: Add tests for additional snippets
ashutoshgautams Sep 18, 2024
c0df3f1
Merge branch 'core-heading-test' of https://github.com/rtcamp/wp-grap…
justlevine Sep 18, 2024
eaf44ca
chore: phpcbf
justlevine Sep 18, 2024
9be31c6
fix: Update new tests so assertEquals()
ashutoshgautams Sep 18, 2024
7301ed9
feat: Add a changeset for patch
ashutoshgautams Sep 18, 2024
530233b
fix: Fix the remaining annotations and phpcbf
ashutoshgautams Sep 19, 2024
a474a46
fix: Add test coverage for preset color and font
ashutoshgautams Sep 23, 2024
ba1e532
fix: Remove phpcs.xml
ashutoshgautams Sep 23, 2024
110103c
fix: Add doc-blocks, remove duplicate tests
ashutoshgautams Sep 23, 2024
33d60f5
fix: Add a lock attribue test
ashutoshgautams Sep 23, 2024
9bc6fe9
docs: Add explicit list of "previously untested" attributes
ashutoshgautams Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions tests/unit/CoreHeadingTest.php
View file
Open in desktop
justlevine marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ public function test_retrieve_core_heading_with_colors_and_alignment() {
[
'align' => 'wide', // Previously untested
'anchor' => null,
'backgroundColor' => null,
'backgroundColor' => null, // @todo: This is not returning correctly.
'className' => null,
'content' => 'Colored Heading',
'cssClassName' => 'wp-block-heading has-text-align-right has-text-color has-background alignwide',
Expand All @@ -193,7 +193,7 @@ public function test_retrieve_core_heading_with_colors_and_alignment() {
],
]),
'textAlign' => 'right',
'textColor' => null,
'textColor' => null, // @todo: This is not returning correctly.
],
$attributes
);
Expand Down Expand Up @@ -226,21 +226,21 @@ public function test_retrieve_core_heading_with_font_and_anchor() {
$this->assertEquals(
[
'align' => null,
'anchor' => 'custom-id',
'anchor' => 'custom-id', // Previously untested
'backgroundColor' => null,
'className' => null,
'content' => 'Custom Font Heading',
'cssClassName' => 'wp-block-heading',
'fontFamily' => null, // Previously untested
'fontSize' => null,
'fontFamily' => null, // @todo: This is not returning correctly.
'fontSize' => null, // @todo: This is not returning correctly.
justlevine marked this conversation as resolved.
Show resolved Hide resolved
'gradient' => null,
'level' => 2.0,
'lock' => null,
'placeholder' => null,
'style' => wp_json_encode([
'typography' => [
'fontFamily' => 'Arial',
'fontSize' => '32px',
'fontFamily' => 'Arial', // Previously untested
'fontSize' => '32px', // Previously untested
],
]),
'textAlign' => null,
Expand Down Expand Up @@ -284,7 +284,7 @@ public function test_retrieve_core_heading_with_gradient() {
'cssClassName' => 'wp-block-heading has-background',
'fontFamily' => null,
'fontSize' => null,
'gradient' => null, // Previously untested
'gradient' => null, // @todo: This is not returning correctly.
'level' => 2.0,
'lock' => null,
'placeholder' => null,
Expand Down Expand Up @@ -386,7 +386,7 @@ public function test_retrieve_core_heading_with_text_color() {
'placeholder' => null,
'style' => null,
'textAlign' => null,
'textColor' => 'vivid-red',
'textColor' => 'vivid-red', // Previously untested
],
$attributes
);
Expand Down Expand Up @@ -425,7 +425,7 @@ public function test_retrieve_core_heading_with_font_size() {
'content' => 'Heading with Font Size',
'cssClassName' => 'wp-block-heading has-large-font-size',
'fontFamily' => null,
'fontSize' => 'large',
'fontSize' => 'large', // Previously untested
'gradient' => null,
'level' => 2.0,
'lock' => null,
Expand Down Expand Up @@ -467,7 +467,7 @@ public function test_retrieve_core_heading_with_class_name() {
'align' => null,
'anchor' => null,
'backgroundColor' => null,
'className' => 'custom-class',
'className' => 'custom-class', // Previously untested
'content' => 'Heading with Custom Class',
'cssClassName' => 'wp-block-heading custom-class',
'fontFamily' => null,
Expand Down