tests: backfill tests for ContentBlockResolver
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justlevine
changed the base branch from
main
to
dev/refactor-ContentBlocksResolver
justlevine
force-pushed
the
dev/refactor-ContentBlocksResolver
branch
from
f0860a6
to
31944d8
Compare
justlevine
force-pushed
the
test/refactor-ContentBlockResolver
branch
from
ad75095
to
09f83cc
Compare
justlevine
requested changes
Sep 17, 2024
There was a problem hiding this comment.
@Ta5r -
I rebased this PR on the latest dev/refactor-ContentBlocksResolver, so remember to git pul --force before committing any new changes.
justlevine
changed the title
ContentBlockResolver (post-refactor)
justlevine
force-pushed
the
test/refactor-ContentBlockResolver
branch
from
844138a
to
fcde1f2
Compare
justlevine
changed the title
ContentBlockResolver (post-refactor)ContentBlockResolver
justlevine
approved these changes
Sep 21, 2024
There was a problem hiding this comment.
@Ta5r Take a look at c5f0410 where:
- I removed tests that were already being covered (per the previous comments)
- I refactored the inner blocks test so it's more clear what exactly it is asserting (general rule: avoid transforming results, instead create an
::assert*()that holds the relevant transformation logic.
Also cleaned up the PR description (they have CI so no need for a screenshot, and removed the jargon so it's more clearly indicates what's included).
Go ahead and generate a changeset, and open up a PR upstream.
justlevine
added
the
has-upstream-pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking: wpengine#292 (comment)
What
This PR backfills additional test cases for the
ContentBlocksResolverclass inContentBlocksResolverTest.How
The following test cases are included:
test_pre_resolved_blocks_filter_returns_non_nullensures that thewpgraphql_content_blocks_pre_resolve_blocksfilter correctly modifies the block content before the blocks are resolved.test_returns_empty_array_for_empty_contentchecks that an empty array is returned when the post content is empty, ensuring proper behavior for posts with no blocks.test_filters_wpgraphql_content_blocks_resolve_blocksensures that thewpgraphql_content_blocks_resolve_blocksfilter correctly modifies block content after the blocks are resolved.test_inner_blockstests resolution for both flat and nested blocks, including the correctparentClientIdsare set, and that there are no discrepancies between flat/nested resolution.