tests : Add tests for Core Quote block.
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was reset and cherrypicked to undo the bad merges/rebases Co-authored-by: Ta5r <srv.tanay@gmail.com>
justlevine
force-pushed
the
core-quote-test
branch
from
a4c2670
to
6d97815
Compare
justlevine
reviewed
Sep 21, 2024
justlevine
reviewed
Sep 21, 2024
justlevine
reviewed
Sep 21, 2024
justlevine
reviewed
Sep 21, 2024
justlevine
reviewed
Sep 21, 2024
justlevine
reviewed
Sep 21, 2024
justlevine
reviewed
Sep 21, 2024
justlevine
reviewed
Sep 21, 2024
justlevine
reviewed
Sep 21, 2024
justlevine
reviewed
Sep 23, 2024
justlevine
reviewed
Sep 24, 2024
tests/unit/CoreQuoteTest.php
Outdated
Comment on lines
153
to
154
| 'layout' => null, | ||
| 'textAlign' => null, |
There was a problem hiding this comment.
You removed these from the query entirely, so they should be removed here, not exiting with a value of null (ref: https://github.com/rtCamp/wp-graphql-content-blocks/actions/runs/11011696682/job/30576344056?pr=23#step:8:282)
There was a problem hiding this comment.
yupp, i justt figured that out 😓
There was a problem hiding this comment.
no need to comment them out, just remove them.
justlevine
reviewed
Sep 24, 2024
justlevine
reviewed
Sep 24, 2024
justlevine
reviewed
Sep 24, 2024
.changeset/thirty-chicken-drum.md
Outdated
| "@wpengine/wp-graphql-content-blocks": patch | ||
| --- | ||
|
|
||
| test : Core Quote block fields and attributes. |
justlevine
requested changes
Sep 24, 2024
justlevine
approved these changes
Sep 24, 2024
justlevine
added
the
has-upstream-pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking wpengine#299
What:
This PR backfills tests for the
Core Quoteblock and its attributes.Tested attributes :
Untested fields:
CoreQuoteAttributes.metadata- @todoExposed issues:
NA