-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Modern C++ DL example #632
Conversation
The compilation is starting. Take a look here. |
The compilation is starting. Take a look here. |
The compilation is starting. Take a look here. |
Everything is OK. Thank you for the PR! |
2 similar comments
Everything is OK. Thank you for the PR! |
Everything is OK. Thank you for the PR! |
The compilation is starting. Take a look here. |
Everything is OK. Thank you for the PR! |
Hey @luisrg-rti can you move the source code to the main directory similarly to all the other examples? https://github.com/rticommunity/rticonnextdds-examples/tree/develop/examples/connext_dds/asyncwaitset/c%2B%2B11 same with the header file. |
Also take a look to the linting and formatting issues: |
Make the example consistent with the rest:
|
I'll make these changes. I think I may have followed the structure of the other DL examples in |
The compilation is starting. Take a look here. |
The compilation is starting. Take a look here. |
Everything is OK. Thank you for the PR! |
1 similar comment
Everything is OK. Thank you for the PR! |
Hi @luisrg-rti can you add your |
Once the cmake-utils PR is merged, we will launch a final build (after the |
The compilation is starting. Take a look here. |
Oops, something went wrong! |
The compilation is starting. Take a look here. |
The compilation is starting. Take a look here. |
Everything is OK. Thank you for the PR! |
1 similar comment
Everything is OK. Thank you for the PR! |
The compilation is starting. Take a look here. |
The compilation is starting. Take a look here. |
Everything is OK. Thank you for the PR! |
1 similar comment
Everything is OK. Thank you for the PR! |
Seems to be working fine:
|
This example requires changes to the
cmake-utils
sub-repository before it can be compiled