Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Modern C++ DL example #632

Merged
merged 12 commits into from
Nov 20, 2023
Merged

Conversation

luisrg-rti
Copy link
Contributor

This example requires changes to the cmake-utils sub-repository before it can be compiled

@github-actions
Copy link

The compilation is starting. Take a look here.

@luisrg-rti luisrg-rti marked this pull request as draft October 24, 2023 20:41
@github-actions
Copy link

The compilation is starting. Take a look here.

@github-actions
Copy link

The compilation is starting. Take a look here.

@github-actions
Copy link

Everything is OK. Thank you for the PR!

2 similar comments
@github-actions
Copy link

Everything is OK. Thank you for the PR!

@github-actions
Copy link

Everything is OK. Thank you for the PR!

@github-actions
Copy link

The compilation is starting. Take a look here.

@github-actions
Copy link

Everything is OK. Thank you for the PR!

@lulivi
Copy link
Collaborator

lulivi commented Oct 26, 2023

Hey @luisrg-rti can you move the source code to the main directory similarly to all the other examples? https://github.com/rticommunity/rticonnextdds-examples/tree/develop/examples/connext_dds/asyncwaitset/c%2B%2B11 same with the header file.

@lulivi
Copy link
Collaborator

lulivi commented Oct 26, 2023

@alexcamposruiz
Copy link
Contributor

Make the example consistent with the rest:

  1. Move to connext_dds
  2. Create a top-level README with language-independent description of the example, and mention that for other languages the examples are shipped (see the basic_security example for ex)
  3. Move all sources to c++11 (remove src and include dirs)
  4. Make the c++11/README.md focus on how to run the c++11 example only.

@luisrg-rti
Copy link
Contributor Author

luisrg-rti commented Oct 26, 2023

Make the example consistent with the rest:

1. Move to connext_dds

2. Create a top-level README with language-independent description of the example, and mention that for other languages the examples are shipped (see the basic_security example for ex)

3. Move all sources to c++11 (remove src and include dirs)

4. Make the c++11/README.md focus on how to run the c++11 example only.

I'll make these changes. I think I may have followed the structure of the other DL examples in connextdds/examples.1.0 instead by mistake.

Copy link

github-actions bot commented Nov 2, 2023

The compilation is starting. Take a look here.

Copy link

github-actions bot commented Nov 2, 2023

The compilation is starting. Take a look here.

Copy link

github-actions bot commented Nov 2, 2023

Everything is OK. Thank you for the PR!

1 similar comment
Copy link

github-actions bot commented Nov 2, 2023

Everything is OK. Thank you for the PR!

@lulivi lulivi marked this pull request as ready for review November 3, 2023 12:59
@lulivi
Copy link
Collaborator

lulivi commented Nov 3, 2023

Hi @luisrg-rti can you add your distributed_logger directory to here? https://github.com/rticommunity/rticonnextdds-examples/blob/master/examples/connext_dds/CMakeLists.txt#L108

@lulivi
Copy link
Collaborator

lulivi commented Nov 3, 2023

Once the cmake-utils PR is merged, we will launch a final build (after the examples/connext_dds/CMakeLists.txt change is done) to check everything working as expected

Copy link

github-actions bot commented Nov 3, 2023

The compilation is starting. Take a look here.

Copy link

github-actions bot commented Nov 3, 2023

Oops, something went wrong!

@luisrg-rti luisrg-rti requested a review from lulivi November 7, 2023 14:54
Copy link

The compilation is starting. Take a look here.

Copy link

The compilation is starting. Take a look here.

Copy link

Everything is OK. Thank you for the PR!

1 similar comment
Copy link

Everything is OK. Thank you for the PR!

Copy link

The compilation is starting. Take a look here.

Copy link

The compilation is starting. Take a look here.

Copy link

Everything is OK. Thank you for the PR!

1 similar comment
Copy link

Everything is OK. Thank you for the PR!

@lulivi lulivi merged commit fe09cf3 into rticommunity:master Nov 20, 2023
3 checks passed
@lulivi
Copy link
Collaborator

lulivi commented Nov 20, 2023

Seems to be working fine:

2023-11-17T07:29:55.8992829Z [ 25%] Building CXX object connext_dds/distributed_logger/c++11/CMakeFiles/DistLoggerExample.dir/DistLoggerExample.cxx.o 
2023-11-17T07:29:57.0808939Z [ 25%] Linking CXX executable DistLoggerExample                        
2023-11-17T07:29:57.1604108Z [ 25%] Built target DistLoggerExample

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants