ROUTING-1234: having the Service as Lib example in Recorder show the … #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…execute_command() API
fgaranda
previously requested changes
Jul 19, 2024
examples/recording_service/service_as_lib/c++11/ServiceAsLibExample.cxx
Outdated
Show resolved
Hide resolved
…ample.cxx Co-authored-by: Fernando García Aranda <fernel@gmail.com>
|
I have retargeted to develop like we mentioned |
|
@fgaranda is on vacation, I'm going to take him out of the review as he provided feedback and has been applied. |
juanlu-rti
dismissed
fgaranda’s stale review
He's out on vacation and provided feedback already
lulivi
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modify some CMake files in recording service examples so that they use the newly shipped library (7.4.0)
rtiserviceadmincpp. Also, modified the exampleservice_as_libso that it showcases the use of theexecute_commandmethod to shut down the service.Details and comments
Checks