Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVALG-77 follow up: Change design to use Last-Value Cache and Read #703

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

EVALG-77 follow up: Change design to use Last-Value Cache and Read #703

wants to merge 13 commits into from
+332 −328

Conversation

Alxe
Copy link
Member

@Alxe Alxe commented Aug 26, 2024

Summary

This PR changes the example to follow a Last-Value Cache pattern on the subscriber. This removes the need for asynchronous code and focuses on polling.

Additionally, a few other changes have been made as left-over TODO from previous PR, #695.

Details and comments

Checks

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

alexcamposruiz
alexcamposruiz reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@alexcamposruiz alexcamposruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix python formatting with black

tutorials/application_design/py/subscriber.py Outdated Show resolved Hide resolved
tutorials/application_design/py/subscriber.py Outdated Show resolved Hide resolved
tutorials/application_design/py/subscriber.py Outdated Show resolved Hide resolved
tutorials/application_design/py/subscriber.py Show resolved Hide resolved
tutorials/application_design/py/subscriber.py Show resolved Hide resolved
tutorials/application_design/py/subscriber.py Outdated Show resolved Hide resolved
tutorials/application_design/py/subscriber.py Outdated Show resolved Hide resolved
tutorials/application_design/py/subscriber.py Outdated Show resolved Hide resolved
tutorials/application_design/py/subscriber.py Outdated Show resolved Hide resolved
tutorials/application_design/py/subscriber.py Outdated Show resolved Hide resolved
alexcamposruiz
alexcamposruiz requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@alexcamposruiz alexcamposruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested several improvements to reduce complexity and improve readability.

@Alxe Alxe self-assigned this Sep 30, 2024
alexcamposruiz
alexcamposruiz requested changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@alexcamposruiz alexcamposruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replied to open comments.

Also, make sure to apply relevant feedback to the C++ example as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcamposruiz alexcamposruiz Awaiting requested review from alexcamposruiz

Requested changes must be addressed to merge this pull request.

Assignees

@Alxe Alxe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alxe @alexcamposruiz