Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JH-76 -- update master README.md to show new 7.4.0 link. This is not a code change .. #721

Closed
wants to merge 4 commits into from
Closed

JH-76 -- update master README.md to show new 7.4.0 link. This is not a code change .. #721

wants to merge 4 commits into from

Conversation

alvinkrebs
Copy link
Collaborator

@alvinkrebs alvinkrebs commented Oct 10, 2024 •
edited
Loading

Summary

update master README.md to show new 7.4.0 link. This is not a code change ..

Details and comments

From my fork ...

git checkout release/7.4.0 && git pull
git checkout master && git pull
git checkout -b feature/JH-76-update-master-README
## edit README.md
## add link to 7.4.0 and mention the EAR available for viewing
git add README.md
git commit -m "JH-76 -- update the master README.md with new 7.4.0 link. This is not a code change ..."
git push origin feature/JH-76-update-master-README

Checks

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

elainerti
elainerti reviewed Oct 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
elainerti
elainerti reviewed Oct 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@alvinkrebs
Revert "JH-76 -- copy over the latest README.md into master. This is …
f7f5f25 
…not a code change commit ..."

This reverts commit b1c640b.

We don't want to change the content of the README.md, just add another non-master link to 7.4.0
@alvinkrebs
JH-76 -- just add the 7.4.0 non-master link ...
82ddda0
@alvinkrebs
JH-76 -- mention EAR for other non-master links ...
592e375
@alvinkrebs alvinkrebs changed the title JH-76 -- copy over the latest README.md into master. This is not a code change .. JH-76 -- update master README.md to show new 7.4.0 link. This is not a code change .. Oct 10, 2024
@alexcamposruiz
Copy link
Contributor

I had already created a PR to do this: #708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elainerti elainerti elainerti left review comments

@alexcamposruiz alexcamposruiz Awaiting requested review from alexcamposruiz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alvinkrebs @alexcamposruiz @elainerti