#fix REQREPLY-221: Update RPC examples #723
Conversation
…alive by the time we call finalize factory
| @@ -81,31 +81,17 @@ class InventoryImpl : public InventoryService { | |||
| std::mutex mutex; | |||
| }; | |||
|
|
|||
There was a problem hiding this comment.
I created this function because we were creating the participnat in the same scope where we were calling dds::domain::DomainParticipant::finalize_participant_factory();. So the participant destructor was not invoked by the time the factory was finalized. producing a precondition error
| @@ -126,7 +112,38 @@ int main(int argc, char *argv[]) | |||
| ::InventoryServiceService service(service_impl, server, params); | |||
|
|
|||
| std::cout << "InventoryService running... " << std::endl; | |||
| server.run(); | |||
| server.run(std::chrono::seconds(service_timeout)); | |||
There was a problem hiding this comment.
For us to test the examples they have to run in a given time, they cannot run forever
|
The target branch can't be master; master contains code compatible with 7.3.0. You have to use develop for changes that will be supported in the next release. There's a caveat here though. The changes to |
| " -q, --quantity <int> Number of items to add or remove\n"\ | ||
| " Default: 1\n" | ||
| " -s, --service-timeout <int> Numbers of senconds the service will run\n"\ | ||
| " Default: 60\n" |
There was a problem hiding this comment.
let's keep the default unlimited
|
The changes have been moved the following PR |
Summary
With this PR we want to update RPC examples to use wait for service
Details and comments
I have also updated the examples so they finish at some point, we need it to test them
Checks