Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch over to GitHub Actions and fix various issues with the test suite #368

Merged
merged 11 commits into from
Jul 22, 2022

Conversation

judofyr
Copy link
Collaborator

@judofyr judofyr commented Jul 18, 2022

This is in order to prepare a new release.

@ntkme: Could you have a look at this and see if it makes sense?

Pending work to make all tests work:

@judofyr judofyr self-assigned this Jul 18, 2022
Copy link
Contributor

@ntkme ntkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the two issues you already found. I will do some test for RDiscount in my environment and see if I can reproduce it.

@ntkme
Copy link
Contributor

ntkme commented Jul 18, 2022

@judofyr Seems like there is a weird conflict between loading bluecloth and rdiscount. - If you try to add a require 'rdiscount' anywhere before require 'bluecloth', the rdiscount test will pass and the bluecloth test now fails. At quick test shows, whoever gets loads first between the two wins, but I haven't got a chance to look at exactly why.

@ntkme
Copy link
Contributor

ntkme commented Jul 18, 2022

The issue is that both bluecloth and rdiscount are bundling a native extension for discount. bluecloth bundles 2.0.6 but rdiscount bundles 2.2.0. I think the best way to deal with it is to isolate the two from being tested together.

@judofyr
Copy link
Collaborator Author

judofyr commented Jul 19, 2022

@judofyr Seems like there is a weird conflict between loading bluecloth and rdiscount. - If you try to add a require 'rdiscount' anywhere before require 'bluecloth', the rdiscount test will pass and the bluecloth test now fails. At quick test shows, whoever gets loads first between the two wins, but I haven't got a chance to look at exactly why.

Oh wow! What a great find. I've seen this errors for years and never understood the reason for it. I think the most sensible thing is to not test for BlueCloth. It's a very old package anyway and not actively maintained.

@judofyr
Copy link
Collaborator Author

judofyr commented Jul 22, 2022

Alrighty, @ntkme, I think I've fixed all the problems now! Looks good?

Copy link
Contributor

@ntkme ntkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@judofyr judofyr merged commit a3cd20d into master Jul 22, 2022
@judofyr judofyr deleted the gh-actions branch July 22, 2022 19:10
@mishina2228 mishina2228 mentioned this pull request Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants