-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch over to GitHub Actions and fix various issues with the test suite #368
Conversation
We currently don't handle all of these. Let's instead add support if they're requested. Alternatively we could make it more dynamic.
This seems to fix the test error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except the two issues you already found. I will do some test for RDiscount in my environment and see if I can reproduce it.
@judofyr Seems like there is a weird conflict between loading bluecloth and rdiscount. - If you try to add a |
The issue is that both bluecloth and rdiscount are bundling a native extension for discount. bluecloth bundles 2.0.6 but rdiscount bundles 2.2.0. I think the best way to deal with it is to isolate the two from being tested together. |
Oh wow! What a great find. I've seen this errors for years and never understood the reason for it. I think the most sensible thing is to not test for BlueCloth. It's a very old package anyway and not actively maintained. |
Alrighty, @ntkme, I think I've fixed all the problems now! Looks good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This is in order to prepare a new release.
@ntkme: Could you have a look at this and see if it makes sense?
Pending work to make all tests work: