forked from opensearch-project/OpenSearch-Dashboards
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
share saved objects to workspace api (#67)
* share saved objects to workspace api Signed-off-by: Hailong Cui <ihailong@amazon.com> * using script for bulk update Signed-off-by: Hailong Cui <ihailong@amazon.com> * filter out pulbic saved objects when sharing Signed-off-by: Hailong Cui <ihailong@amazon.com> * refactor saved object permission error Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix merge issue Signed-off-by: Hailong Cui <ihailong@amazon.com> * permission check for target workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * move source workspace existence validation to repository Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>
- Loading branch information
1 parent
69d7e65
commit 340bfcc
Showing
10 changed files
with
309 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,102 @@ | ||
/* | ||
* Copyright OpenSearch Contributors | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
import { schema } from '@osd/config-schema'; | ||
import { IRouter } from '../../http'; | ||
import { exportSavedObjectsToStream } from '../export'; | ||
import { validateObjects } from './utils'; | ||
import { collectSavedObjects } from '../import/collect_saved_objects'; | ||
import { WORKSPACE_TYPE } from '../../workspaces'; | ||
import { GLOBAL_WORKSPACE_ID } from '../../workspaces/constants'; | ||
|
||
const SHARE_LIMIT = 10000; | ||
|
||
export const registerShareRoute = (router: IRouter) => { | ||
router.post( | ||
{ | ||
path: '/_share', | ||
validate: { | ||
body: schema.object({ | ||
sourceWorkspaceId: schema.maybe(schema.string()), | ||
objects: schema.arrayOf( | ||
schema.object({ | ||
id: schema.string(), | ||
type: schema.string(), | ||
}) | ||
), | ||
targetWorkspaceIds: schema.arrayOf(schema.string()), | ||
}), | ||
}, | ||
}, | ||
router.handleLegacyErrors(async (context, req, res) => { | ||
const savedObjectsClient = context.core.savedObjects.client; | ||
const { sourceWorkspaceId, objects, targetWorkspaceIds } = req.body; | ||
|
||
// need to access the registry for type validation, can't use the schema for this | ||
const supportedTypes = context.core.savedObjects.typeRegistry | ||
.getAllTypes() | ||
.filter((type) => type.name !== WORKSPACE_TYPE) | ||
.map((t) => t.name); | ||
|
||
if (objects) { | ||
const validationError = validateObjects(objects, supportedTypes); | ||
if (validationError) { | ||
return res.badRequest({ | ||
body: { | ||
message: validationError, | ||
}, | ||
}); | ||
} | ||
} | ||
|
||
const objectsListStream = await exportSavedObjectsToStream({ | ||
savedObjectsClient, | ||
objects, | ||
exportSizeLimit: SHARE_LIMIT, | ||
includeReferencesDeep: true, | ||
excludeExportDetails: true, | ||
}); | ||
|
||
const collectSavedObjectsResult = await collectSavedObjects({ | ||
readStream: objectsListStream, | ||
objectLimit: SHARE_LIMIT, | ||
supportedTypes, | ||
}); | ||
|
||
const savedObjects = collectSavedObjectsResult.collectedObjects; | ||
|
||
const nonPublicSharedObjects = savedObjects | ||
// non-public | ||
.filter( | ||
(obj) => | ||
obj.workspaces && | ||
obj.workspaces.length > 0 && | ||
!obj.workspaces.includes(GLOBAL_WORKSPACE_ID) | ||
) | ||
.map((obj) => ({ id: obj.id, type: obj.type, workspaces: obj.workspaces })); | ||
|
||
if (nonPublicSharedObjects.length === 0) { | ||
return res.ok({ | ||
body: savedObjects.map((savedObject) => ({ | ||
type: savedObject.type, | ||
id: savedObject.id, | ||
workspaces: savedObject.workspaces, | ||
})), | ||
}); | ||
} | ||
|
||
const response = await savedObjectsClient.addToWorkspaces( | ||
nonPublicSharedObjects, | ||
targetWorkspaceIds, | ||
{ | ||
workspaces: sourceWorkspaceId ? [sourceWorkspaceId] : undefined, | ||
} | ||
); | ||
return res.ok({ | ||
body: response, | ||
}); | ||
}) | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.