Skip to content

Commit

Permalink
feat: change public logic
Browse files Browse the repository at this point in the history
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
  • Loading branch information
SuZhou-Joe committed Aug 9, 2023
1 parent 6d9b8c3 commit 36bae5f
Showing 1 changed file with 3 additions and 17 deletions.
20 changes: 3 additions & 17 deletions src/core/server/saved_objects/service/lib/repository.ts
Original file line number Diff line number Diff line change
Expand Up @@ -221,14 +221,6 @@ export class SavedObjectsRepository {
this._serializer = serializer;
}

private isPublicWorkspace(workspaces?: string[]) {
if (!workspaces || workspaces.includes('public')) {
return true;
}

return false;
}

/**
* This function will compute the exclude workspaces from baseWorkspaces
*/
Expand Down Expand Up @@ -494,16 +486,12 @@ export class SavedObjectsRepository {
}

if (expectedBulkGetResult.value.method === 'create') {
if (!this.isPublicWorkspace(options.workspaces)) {
savedObjectWorkspaces = options.workspaces;
}
savedObjectWorkspaces = options.workspaces;
} else {
const changeToCreate = () => {
finalMethod = 'create';
finalObjectId = object.id;
savedObjectWorkspaces = this.isPublicWorkspace(options.workspaces)
? undefined
: options.workspaces;
savedObjectWorkspaces = options.workspaces;
versionProperties = {};
};
/**
Expand Down Expand Up @@ -538,9 +526,7 @@ export class SavedObjectsRepository {
savedObjectWorkspaces = transformedObject.workspaces;
}
} else {
savedObjectWorkspaces = this.isPublicWorkspace(options.workspaces)
? undefined
: options.workspaces;
savedObjectWorkspaces = options.workspaces;
}
}

Expand Down

0 comments on commit 36bae5f

Please sign in to comment.