fix: incorrect permission modes when checking workspace permissions (#98

) Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
ruanyl · Sep 15, 2023 · 3fde67a · 3fde67a
1 parent fe8bb1e
commit 3fde67a
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts b/src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts
@@ -175,7 +175,7 @@ export class WorkspaceSavedObjectsClientWrapper {
       await this.validateMultiWorkspacesPermissions(
         objectToDeleted.workspaces,
         wrapperOptions.request,
-        WorkspacePermissionMode.Management
+        [WorkspacePermissionMode.LibraryWrite, WorkspacePermissionMode.Management]
       );
       return await wrapperOptions.client.delete(type, id, options);
     };
@@ -238,7 +238,7 @@ export class WorkspaceSavedObjectsClientWrapper {
         await this.validateMultiWorkspacesPermissions(
           attributes.workspaces,
           wrapperOptions.request,
-          WorkspacePermissionMode.Management
+          [WorkspacePermissionMode.LibraryWrite, WorkspacePermissionMode.Management]
         );
       }
       return await wrapperOptions.client.create(type, attributes, options);
@@ -253,7 +253,11 @@ export class WorkspaceSavedObjectsClientWrapper {
       await this.validateAtLeastOnePermittedWorkspaces(
         objectToGet.workspaces,
         wrapperOptions.request,
-        WorkspacePermissionMode.Read
+        [
+          WorkspacePermissionMode.LibraryRead,
+          WorkspacePermissionMode.LibraryWrite,
+          WorkspacePermissionMode.Management,
+        ]
       );
       return objectToGet;
     };
@@ -267,7 +271,11 @@ export class WorkspaceSavedObjectsClientWrapper {
         await this.validateAtLeastOnePermittedWorkspaces(
           object.workspaces,
           wrapperOptions.request,
-          WorkspacePermissionMode.Read
+          [
+            WorkspacePermissionMode.LibraryRead,
+            WorkspacePermissionMode.LibraryWrite,
+            WorkspacePermissionMode.Management,
+          ]
         );
       }
       return objectToBulkGet;