feat: update read / write to library_read / library_write

Signed-off-by: Lin Wang <wonglam@amazon.com>
ruanyl · Aug 8, 2023 · 6de5b29 · 6de5b29
1 parent f27ebdb
commit 6de5b29
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 17 deletions.
diff --git a/src/core/server/workspaces/routes/index.ts b/src/core/server/workspaces/routes/index.ts
@@ -13,8 +13,8 @@ import { IWorkspaceDBImpl, WorkspaceRoutePermissionItem } from '../types';
 const WORKSPACES_API_BASE_URL = '/api/workspaces';
 
 const workspacePermissionMode = schema.oneOf([
-  schema.literal(PermissionMode.Read),
-  schema.literal(PermissionMode.Write),
+  schema.literal(PermissionMode.LibraryRead),
+  schema.literal(PermissionMode.LibraryWrite),
   schema.literal(PermissionMode.Management),
 ]);
 

diff --git a/src/core/server/workspaces/types.ts b/src/core/server/workspaces/types.ts
@@ -77,5 +77,7 @@ export type IResponse<T> =
     };
 
 export type WorkspaceRoutePermissionItem = {
-  modes: Array<PermissionMode.Read | PermissionMode.Write | PermissionMode.Management>;
+  modes: Array<
+    PermissionMode.LibraryRead | PermissionMode.LibraryWrite | PermissionMode.Management
+  >;
 } & ({ type: 'user'; userId: string } | { type: 'group'; group: string });
diff --git a/...gins/workspace/public/components/workspace_creator/workspace_permission_setting_panel.tsx b/...gins/workspace/public/components/workspace_creator/workspace_permission_setting_panel.tsx
@@ -26,20 +26,20 @@ export type WorkspacePermissionSetting = (
   userId?: string;
   group?: string;
   modes: Array<
-    | WorkspacePermissionMode.Read
-    | WorkspacePermissionMode.Write
+    | WorkspacePermissionMode.LibraryRead
+    | WorkspacePermissionMode.LibraryWrite
     | WorkspacePermissionMode.Management
   >;
 };
 
 const permissionModeOptions = [
   {
-    id: WorkspacePermissionMode.Read,
+    id: WorkspacePermissionMode.LibraryRead,
     label: 'View',
     iconType: 'eye',
   },
   {
-    id: WorkspacePermissionMode.Write,
+    id: WorkspacePermissionMode.LibraryWrite,
     label: 'Edit',
     iconType: 'pencil',
   },
@@ -58,11 +58,11 @@ const permissionTypeOptions = [
 const isWorkspacePermissionMode = (
   test: string
 ): test is
-  | WorkspacePermissionMode.Read
-  | WorkspacePermissionMode.Write
+  | WorkspacePermissionMode.LibraryRead
+  | WorkspacePermissionMode.LibraryWrite
   | WorkspacePermissionMode.Management =>
-  test === WorkspacePermissionMode.Read ||
-  test === WorkspacePermissionMode.Write ||
+  test === WorkspacePermissionMode.LibraryRead ||
+  test === WorkspacePermissionMode.LibraryWrite ||
   test === WorkspacePermissionMode.Management;
 
 interface WorkspacePermissionSettingInputProps {
@@ -72,8 +72,8 @@ interface WorkspacePermissionSettingInputProps {
   userId?: string;
   group?: string;
   modes?: Array<
-    | WorkspacePermissionMode.Read
-    | WorkspacePermissionMode.Write
+    | WorkspacePermissionMode.LibraryRead
+    | WorkspacePermissionMode.LibraryWrite
     | WorkspacePermissionMode.Management
   >;
   onTypeChange: (type: 'user' | 'group', index: number) => void;
@@ -86,8 +86,8 @@ interface WorkspacePermissionSettingInputProps {
   ) => void;
   onPermissionModesChange: (
     WorkspacePermissionMode: Array<
-      | WorkspacePermissionMode.Read
-      | WorkspacePermissionMode.Write
+      | WorkspacePermissionMode.LibraryRead
+      | WorkspacePermissionMode.LibraryWrite
       | WorkspacePermissionMode.Management
     >,
     index: number
@@ -113,8 +113,10 @@ const WorkspacePermissionSettingInput = ({
   );
   const permissionModesIdToSelectMap = useMemo(
     () => ({
-      [WorkspacePermissionMode.Read]: !!modes?.includes(WorkspacePermissionMode.Read),
-      [WorkspacePermissionMode.Write]: !!modes?.includes(WorkspacePermissionMode.Write),
+      [WorkspacePermissionMode.LibraryRead]: !!modes?.includes(WorkspacePermissionMode.LibraryRead),
+      [WorkspacePermissionMode.LibraryWrite]: !!modes?.includes(
+        WorkspacePermissionMode.LibraryWrite
+      ),
       [WorkspacePermissionMode.Management]: !!modes?.includes(WorkspacePermissionMode.Management),
     }),
     [modes]