feat: some side effects

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
ruanyl · Jul 31, 2023 · d325d98 · d325d98
1 parent 2667129
commit d325d98
Showing 1 changed file with 13 additions and 4 deletions.
diff --git a/src/core/server/workspaces/saved_objects/workspace_saved_objects_client_wrapper.ts b/src/core/server/workspaces/saved_objects/workspace_saved_objects_client_wrapper.ts
@@ -41,6 +41,15 @@ const isWorkspacesLikeAttributes = (attributes: unknown): attributes is Attribut
   Array.isArray((attributes as { workspaces: unknown }).workspaces);
 
 export class WorkspaceSavedObjectsClientWrapper {
+  private formatPermissionModeToStringArray(
+    permission: PermissionMode | PermissionMode[]
+  ): string[] {
+    if (Array.isArray(permission)) {
+      return permission;
+    }
+
+    return [permission];
+  }
   private async validateMultiWorkspacesPermissions(
     workspaces: string[] | undefined,
     request: OpenSearchDashboardsRequest,
@@ -57,7 +66,7 @@ export class WorkspaceSavedObjectsClientWrapper {
             type: WORKSPACE_TYPE,
             id: workspaceId,
           },
-          permissionMode
+          this.formatPermissionModeToStringArray(permissionMode)
         ))
       ) {
         throw generateWorkspacePermissionError();
@@ -82,7 +91,7 @@ export class WorkspaceSavedObjectsClientWrapper {
             type: WORKSPACE_TYPE,
             id: workspaceId,
           },
-          permissionMode
+          this.formatPermissionModeToStringArray(permissionMode)
         )
       ) {
         permitted = true;
@@ -172,15 +181,15 @@ export class WorkspaceSavedObjectsClientWrapper {
                 type: WORKSPACE_TYPE,
                 id: workspaceId,
               },
-              PermissionMode.Read
+              this.formatPermissionModeToStringArray(PermissionMode.Read)
             )
         );
       } else {
         options.workspaces = [
           'public',
           ...(await this.permissionControl.getPermittedWorkspaceIds(
             wrapperOptions.request,
-            PermissionMode.Read
+            this.formatPermissionModeToStringArray(PermissionMode.Read)
           )),
         ];
       }