From ddee6a955319c56814e8bbf3b42eed8a531e3586 Mon Sep 17 00:00:00 2001 From: tygao Date: Fri, 18 Aug 2023 11:36:47 +0800 Subject: [PATCH] update addToWorkspacesWithPermissionControl Signed-off-by: tygao --- .../workspace_saved_objects_client_wrapper.ts | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts b/src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts index 701bfc989e53..7f08b565d9ea 100644 --- a/src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts +++ b/src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts @@ -425,10 +425,14 @@ export class WorkspaceSavedObjectsClientWrapper { options: SavedObjectsAddToWorkspacesOptions = {} ) => { // target workspaces - await this.validateMultiWorkspacesPermissions(targetWorkspaces, wrapperOptions.request, [ - WorkspacePermissionMode.LibraryWrite, - WorkspacePermissionMode.Management, - ]); + const workspacePermitted = await this.validateMultiWorkspacesPermissions( + targetWorkspaces, + wrapperOptions.request, + [WorkspacePermissionMode.LibraryWrite, WorkspacePermissionMode.Management] + ); + if (!workspacePermitted) { + throw generateWorkspacePermissionError(); + } // saved_objects const permitted = await this.permissionControl.batchValidate(