Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter applications according to categories #103

Merged
merged 9 commits into from
Aug 25, 2023
Merged

feat: filter applications according to categories #103

merged 9 commits into from
Aug 25, 2023

Conversation

yuye-aws
Copy link
Collaborator

@yuye-aws yuye-aws commented Aug 24, 2023

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2023

Codecov Report

Merging #103 (79f5745) into workspace (c83393b) will increase coverage by 0.01%.
Report is 1 commits behind head on workspace.
The diff coverage is 77.77%.

@@              Coverage Diff              @@
##           workspace     #103      +/-   ##
=============================================
+ Coverage      65.78%   65.79%   +0.01%     
=============================================
  Files           3335     3335              
  Lines          64443    64446       +3     
  Branches       10259    10260       +1     
=============================================
+ Hits           42395    42404       +9     
+ Misses         19476    19473       -3     
+ Partials        2572     2569       -3     
Flag Coverage Δ
Linux_1 34.75% <0.00%> (?)
Linux_3 42.70% <0.00%> (?)
Windows_1 34.76% <0.00%> (-0.01%) ⬇️
Windows_2 54.74% <77.77%> (+<0.01%) ⬆️
Windows_3 42.70% <0.00%> (-0.01%) ⬇️
Windows_4 34.77% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...public/chrome/ui/header/collapsible_nav_header.tsx 60.00% <ø> (ø)
.../core/public/chrome/nav_links/nav_links_service.ts 90.00% <50.00%> (ø)
...c/core/public/chrome/ui/header/collapsible_nav.tsx 92.53% <85.71%> (-1.22%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yuye-aws yuye-aws requested a review from wanglam August 25, 2023 03:02
@yuye-aws yuye-aws merged commit a058a37 into ruanyl:workspace Aug 25, 2023
48 of 50 checks passed
@yuye-aws yuye-aws deleted the filter branch August 25, 2023 14:26
SuZhou-Joe pushed a commit that referenced this pull request Aug 31, 2023
* add features for public workspace

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change default header name

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove recently visited category in management workspace

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change default header name

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change icon and title for workspace overview

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add overview to management workspace featuer

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* bug fix: only show recently visited if the workspace has no feature

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add recently visited when workspace disabled

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change default value from null to undefined

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

---------

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 31, 2023
* add features for public workspace

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change default header name

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove recently visited category in management workspace

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change default header name

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change icon and title for workspace overview

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add overview to management workspace featuer

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* bug fix: only show recently visited if the workspace has no feature

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add recently visited when workspace disabled

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change default value from null to undefined

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

---------

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
ruanyl pushed a commit that referenced this pull request Sep 15, 2023
* add features for public workspace

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change default header name

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove recently visited category in management workspace

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change default header name

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change icon and title for workspace overview

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add overview to management workspace featuer

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* bug fix: only show recently visited if the workspace has no feature

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add recently visited when workspace disabled

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change default value from null to undefined

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

---------

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants