Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide permission section in the workspace create and update page #108

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Aug 25, 2023

Description

  1. add workspace settings API and observable
  2. Hide permission section in the workspace create and update page when permission not enabled

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@wanglam wanglam force-pushed the feat-hide-workspace-permission-when-permission-disabled branch from 00db5fb to 8ae4713 Compare August 25, 2023 02:27
@wanglam wanglam force-pushed the feat-hide-workspace-permission-when-permission-disabled branch from 8ae4713 to 31a3d84 Compare August 25, 2023 03:10
@wanglam wanglam marked this pull request as ready for review August 25, 2023 03:46
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2023

Codecov Report

Merging #108 (ca3f8ba) into workspace (e2f277c) will decrease coverage by 18.41%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           workspace     #108       +/-   ##
==============================================
- Coverage      65.77%   47.36%   -18.41%     
==============================================
  Files           3336     2582      -754     
  Lines          64493    52057    -12436     
  Branches       10264     8363     -1901     
==============================================
- Hits           42418    24659    -17759     
- Misses         19502    25922     +6420     
+ Partials        2573     1476     -1097     
Flag Coverage Δ
Linux_1 34.75% <ø> (ø)
Linux_3 42.64% <ø> (-0.01%) ⬇️
Windows_1 ?
Windows_2 ?
Windows_3 ?
Windows_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1388 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wanglam wanglam force-pushed the feat-hide-workspace-permission-when-permission-disabled branch from 31a3d84 to ca3f8ba Compare August 28, 2023 07:27
@wanglam
Copy link
Collaborator Author

wanglam commented Sep 14, 2023

Close due to low priority, will reopen it in the future.

@wanglam wanglam closed this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants