Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify ACL of advanced settings when switching feature flag. #110

Closed

Conversation

SuZhou-Joe
Copy link
Collaborator

@SuZhou-Joe SuZhou-Joe commented Aug 28, 2023

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@SuZhou-Joe SuZhou-Joe changed the title feat: modify ACL of advanced settings feat: modify ACL of advanced settings when switching feature flag. Aug 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2023

Codecov Report

Merging #110 (ba7910f) into workspace (220bb9d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##           workspace     #110      +/-   ##
=============================================
- Coverage      65.77%   65.76%   -0.01%     
=============================================
  Files           3337     3337              
  Lines          64497    64503       +6     
  Branches       10267    10269       +2     
=============================================
- Hits           42421    42419       -2     
- Misses         19500    19507       +7     
- Partials        2576     2577       +1     
Flag Coverage Δ
Linux_1 34.75% <ø> (ø)
Linux_3 42.63% <0.00%> (-0.02%) ⬇️
Windows_1 34.77% <ø> (ø)
Windows_2 54.73% <0.00%> (-0.02%) ⬇️
Windows_3 42.64% <0.00%> (-0.01%) ⬇️
Windows_4 34.73% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...erver/saved_objects/service/lib/repository.mock.ts 100.00% <ø> (ø)
...ore/server/saved_objects/service/lib/repository.ts 81.75% <0.00%> (-0.93%) ⬇️
...re/server/ui_settings/saved_objects/ui_settings.ts 33.33% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe marked this pull request as draft September 4, 2023 10:13
@SuZhou-Joe SuZhou-Joe closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants