Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update unit test snapshot for header #164

Merged
merged 1 commit into from
Sep 15, 2023
Merged

fix: update unit test snapshot for header #164

merged 1 commit into from
Sep 15, 2023

Conversation

yuye-aws
Copy link
Collaborator

@yuye-aws yuye-aws commented Sep 15, 2023

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2023

Codecov Report

Merging #164 (850079a) into workspace (f350eb3) will increase coverage by 0.04%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           workspace     #164      +/-   ##
=============================================
+ Coverage      65.71%   65.75%   +0.04%     
=============================================
  Files           3336     3336              
  Lines          64652    64652              
  Branches       10316    10316              
=============================================
+ Hits           42484    42510      +26     
+ Misses         19688    19590      -98     
- Partials        2480     2552      +72     
Flag Coverage Δ
Linux_1 34.75% <ø> (ø)
Linux_2 54.70% <ø> (?)
Linux_3 42.54% <ø> (ø)
Linux_4 34.70% <ø> (ø)
Windows_1 34.76% <ø> (ø)
Windows_2 54.67% <ø> (ø)
Windows_3 42.55% <ø> (?)
Windows_4 34.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yuye-aws yuye-aws merged commit c381532 into ruanyl:workspace Sep 15, 2023
40 of 52 checks passed
@opensearch-workspace-development

The backport to workspace-2.9 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9 workspace-2.9
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9
# Create a new branch
git switch --create backport/backport-164-to-workspace-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c381532a94d63009fe786965a9c9f00829d43b23
# Push it to GitHub
git push --set-upstream origin backport/backport-164-to-workspace-2.9
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9

Then, create a pull request where the base branch is workspace-2.9 and the compare/head branch is backport/backport-164-to-workspace-2.9.

ruanyl pushed a commit that referenced this pull request Sep 15, 2023
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Sep 16, 2023
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
@yuye-aws yuye-aws deleted the workspace_tmp branch September 18, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants