Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unit test for mountWrapper #223

Conversation

SuZhou-Joe
Copy link
Collaborator

@SuZhou-Joe SuZhou-Joe commented Oct 11, 2023

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Merging #223 (2e5809f) into workspace-pr-integr (903e594) will increase coverage by 0.42%.
The diff coverage is n/a.

@@                   Coverage Diff                   @@
##           workspace-pr-integr     #223      +/-   ##
=======================================================
+ Coverage                66.06%   66.48%   +0.42%     
=======================================================
  Files                     3386     3412      +26     
  Lines                    64872    65231     +359     
  Branches                 10455    10456       +1     
=======================================================
+ Hits                     42858    43371     +513     
+ Misses                   19446    19337     -109     
+ Partials                  2568     2523      -45     
Flag Coverage Δ
Linux_ 66.07% <ø> (+<0.01%) ⬆️
_1 34.82% <ø> (?)
_2 ?
_3 44.49% <ø> (?)
_4 34.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 94 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@raintygao raintygao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codecov check still failed with decrease, looks strange.

@SuZhou-Joe
Copy link
Collaborator Author

The codecov check still failed with decrease, looks strange.

Raised now, ci-group 1 failed for unknow cancellation on CI flow.

@SuZhou-Joe SuZhou-Joe merged commit 0906bf4 into ruanyl:workspace-pr-integr Oct 12, 2023
36 of 37 checks passed
opensearch-workspace-development bot pushed a commit that referenced this pull request Oct 12, 2023
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 0906bf4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe added a commit that referenced this pull request Oct 12, 2023
…nit test for mountWrapper (#224)

* feat: add unit test for mountWrapper (#223)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 0906bf4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat: add patch

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: some update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: tygao <tygao@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
wanglam pushed a commit that referenced this pull request Feb 26, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
ruanyl added a commit that referenced this pull request Mar 6, 2024
ruanyl added a commit that referenced this pull request Mar 7, 2024
…n management and SavedObject management as standalone app, retire dashboard management (#283)

* Revert "Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management (#208)"

This reverts commit 5f09f84.

* Revert "feat: add unit test for mountWrapper (#223)"

This reverts commit a70ce71.

* Revert "fix: cypress tests checkout workspace branch (#252)"

This reverts commit 734c890.

* run cypress with ftr main

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Mar 11, 2024
…n management and SavedObject management as standalone app, retire dashboard management (#283)

* Revert "Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management (#208)"

This reverts commit 5f09f84.

* Revert "feat: add unit test for mountWrapper (#223)"

This reverts commit a70ce71.

* Revert "fix: cypress tests checkout workspace branch (#252)"

This reverts commit 734c890.

* run cypress with ftr main

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe added a commit that referenced this pull request Mar 18, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Mar 18, 2024
…n management and SavedObject management as standalone app, retire dashboard management (#283)

* Revert "Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management (#208)"

This reverts commit 5f09f84.

* Revert "feat: add unit test for mountWrapper (#223)"

This reverts commit a70ce71.

* Revert "fix: cypress tests checkout workspace branch (#252)"

This reverts commit 734c890.

* run cypress with ftr main

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants