Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport workspace] patch with retire dashboard management and add unit test for mountWrapper #224

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

opensearch-workspace-development[bot]

Backport 0906bf4 from #223.

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 0906bf4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

Merging #224 (d8c43b0) into workspace (c57e880) will increase coverage by 0.05%.
Report is 1 commits behind head on workspace.
The diff coverage is 50.00%.

@@              Coverage Diff              @@
##           workspace     #224      +/-   ##
=============================================
+ Coverage      66.16%   66.22%   +0.05%     
=============================================
  Files           2709     3422     +713     
  Lines          51011    65748   +14737     
  Branches        9207    10587    +1380     
=============================================
+ Hits           33752    43540    +9788     
- Misses         14972    19565    +4593     
- Partials        2287     2643     +356     
Flag Coverage Δ
Linux_1 30.42% <16.66%> (?)
Linux_2 55.35% <ø> (ø)
Linux_3 42.78% <37.50%> (+0.01%) ⬆️
Linux_4 34.53% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ement_app/components/page_wrapper/page_wrapper.tsx 100.00% <100.00%> (ø)
...nt/public/components/page_wrapper/page_wrapper.tsx 100.00% <100.00%> (ø)
.../public/application/components/new_theme_modal.tsx 33.33% <ø> (ø)
.../plugins/index_pattern_management/public/plugin.ts 8.00% <ø> (+0.85%) ⬆️
...ment_section/objects_table/saved_objects_table.tsx 57.03% <ø> (ø)
...c/management_section/page_wrapper/page_wrapper.tsx 100.00% <100.00%> (ø)
.../plugins/saved_objects_management/public/plugin.ts 80.00% <ø> (+8.00%) ⬆️
...gement/public/management_section/mount_section.tsx 14.28% <0.00%> (+1.78%) ⬆️

... and 710 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

raintygao and others added 2 commits October 12, 2023 13:14
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe changed the title [Backport workspace] feat: add unit test for mountWrapper [Backport workspace] patch with retire dashboard management and add unit test for mountWrapper Oct 12, 2023
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe merged commit e36a7b6 into workspace Oct 12, 2023
22 of 23 checks passed
@github-actions github-actions bot deleted the backport/backport-223-to-workspace branch October 12, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants