Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workspace routes integration failed #251

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Feb 27, 2024

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Lin Wang <wonglam@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.02%. Comparing base (089ad04) to head (cfa4d32).

❗ Current head cfa4d32 differs from pull request most recent head 66febdd. Consider uploading reports for the commit 66febdd to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                  @@
##           workspace-pr-integr     #251   +/-   ##
====================================================
  Coverage                67.02%   67.02%           
====================================================
  Files                     3318     3318           
  Lines                    63965    63965           
  Branches                 10255    10255           
====================================================
  Hits                     42871    42871           
  Misses                   18585    18585           
  Partials                  2509     2509           
Flag Coverage Δ
Linux_ 66.35% <ø> (+<0.01%) ⬆️
_1 35.41% <ø> (ø)
_2 55.30% <ø> (ø)
_3 43.42% <ø> (-0.01%) ⬇️
_4 35.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanglam wanglam force-pushed the fix-workspace-routes-integration-tests branch from cfa4d32 to 66febdd Compare February 27, 2024 09:09
@wanglam wanglam marked this pull request as ready for review February 27, 2024 10:00
@wanglam wanglam merged commit 9168d9b into ruanyl:workspace-pr-integr Feb 27, 2024
71 of 89 checks passed
@opensearch-workspace-development

The backport to workspace failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-workspace workspace
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-workspace
# Create a new branch
git switch --create backport/backport-251-to-workspace
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9168d9ba359ef3f20712be2cac3c18d54a5ccec7
# Push it to GitHub
git push --set-upstream origin backport/backport-251-to-workspace
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-workspace

Then, create a pull request where the base branch is workspace and the compare/head branch is backport/backport-251-to-workspace.

@ruanyl
Copy link
Owner

ruanyl commented Feb 28, 2024

@wanglam backport to workspace failed

@wanglam wanglam mentioned this pull request Feb 28, 2024
8 tasks
SuZhou-Joe pushed a commit that referenced this pull request Feb 28, 2024
Signed-off-by: Lin Wang <wonglam@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Lin Wang <wonglam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants