Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual backport #251 #255

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Feb 28, 2024

Description

Manual backport #251

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Lin Wang <wonglam@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.60%. Comparing base (4eb3548) to head (1feace2).

Additional details and impacted files
@@            Coverage Diff             @@
##           workspace     #255   +/-   ##
==========================================
  Coverage      55.60%   55.60%           
==========================================
  Files           2260     2260           
  Lines          42470    42470           
  Branches        7539     7539           
==========================================
  Hits           23616    23616           
  Misses         17394    17394           
  Partials        1460     1460           
Flag Coverage Δ
Linux_2 55.17% <ø> (ø)
Linux_4 34.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanglam wanglam marked this pull request as ready for review February 28, 2024 07:21
@SuZhou-Joe
Copy link
Collaborator

Thanks for fixing the integration test error.

@SuZhou-Joe SuZhou-Joe merged commit e025fd7 into ruanyl:workspace Feb 28, 2024
31 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants