Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove useless code #310

Merged

Conversation

SuZhou-Joe
Copy link
Collaborator

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.05%. Comparing base (efe6254) to head (f0ca6f1).

Additional details and impacted files
@@                   Coverage Diff                   @@
##           workspace-pr-integr     #310      +/-   ##
=======================================================
- Coverage                67.05%   67.05%   -0.01%     
=======================================================
  Files                     3345     3345              
  Lines                    65045    65035      -10     
  Branches                 10505    10502       -3     
=======================================================
- Hits                     43617    43607      -10     
  Misses                   18849    18849              
  Partials                  2579     2579              
Flag Coverage Δ
Linux_ 66.39% <100.00%> (-0.01%) ⬇️
_1 32.60% <0.00%> (+<0.01%) ⬆️
_2 55.36% <100.00%> (-0.03%) ⬇️
_3 43.46% <0.00%> (+<0.01%) ⬆️
_4 35.16% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit e3ce2e2 into ruanyl:workspace-pr-integr Mar 27, 2024
42 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants