replace default workspace with public workspace #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <ihailong@amazon.com>
yubonluo
reviewed
Apr 10, 2024
| export const PUBLIC_WORKSPACE_ID = 'public'; | ||
|
|
||
| export const PUBLIC_WORKSPACE_NAME = i18n.translate('workspaces.public.workspace.default.name', { | ||
| defaultMessage: 'Global workspace', |
There was a problem hiding this comment.
Should the default message be 'Global workspace', I think it is 'public workspace'
There was a problem hiding this comment.
Global workspace(public workspace) has parity with global tenant. To be consistent with global tenant, Global workspace might be a more suitable name
raintygao
approved these changes
Apr 11, 2024
ZilongX
pushed a commit
that referenced
this pull request
Apr 17, 2024
…ensearch-project#6458) * Add workspace filter into saved objects page (#211) * Add workspace column/filter into saved objects page Signed-off-by: Hailong Cui <ihailong@amazon.com> fix failed test case Signed-off-by: Hailong Cui <ihailong@amazon.com> move workspace column to its own folder Signed-off-by: Hailong Cui <ihailong@amazon.com> * default workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> fix test case Signed-off-by: Hailong Cui <ihailong@amazon.com> add test case Signed-off-by: Hailong Cui <ihailong@amazon.com> remove hide import Signed-off-by: Hailong Cui <ihailong@amazon.com> * address review comments Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> * replace default workspace with public workspace (#322) Signed-off-by: Hailong Cui <ihailong@amazon.com> * Add workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> * revert query params change Signed-off-by: Hailong Cui <ihailong@amazon.com> * udpate test case name to more clear Signed-off-by: Hailong Cui <ihailong@amazon.com> * support public workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * Add changelog Signed-off-by: Hailong Cui <ihailong@amazon.com> * update fetchExportByTypeAndSearch parameter Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove virtrual public workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * update comments Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix public workspace query when permission is not enabled Signed-off-by: Hailong Cui <ihailong@amazon.com> * home dashboards/listing page only show public workspace data Signed-off-by: Hailong Cui <ihailong@amazon.com> * Add more test case Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
7 tasks
Hailong-am
added a commit
that referenced
this pull request
Apr 22, 2024
…t page (#6… (#334) * [Workspace] Add Workspace filter to saved objects management page (opensearch-project#6458) * Add workspace filter into saved objects page (#211) * Add workspace column/filter into saved objects page Signed-off-by: Hailong Cui <ihailong@amazon.com> fix failed test case Signed-off-by: Hailong Cui <ihailong@amazon.com> move workspace column to its own folder Signed-off-by: Hailong Cui <ihailong@amazon.com> * default workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> fix test case Signed-off-by: Hailong Cui <ihailong@amazon.com> add test case Signed-off-by: Hailong Cui <ihailong@amazon.com> remove hide import Signed-off-by: Hailong Cui <ihailong@amazon.com> * address review comments Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> * replace default workspace with public workspace (#322) Signed-off-by: Hailong Cui <ihailong@amazon.com> * Add workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> * revert query params change Signed-off-by: Hailong Cui <ihailong@amazon.com> * udpate test case name to more clear Signed-off-by: Hailong Cui <ihailong@amazon.com> * support public workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * Add changelog Signed-off-by: Hailong Cui <ihailong@amazon.com> * update fetchExportByTypeAndSearch parameter Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove virtrual public workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * update comments Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix public workspace query when permission is not enabled Signed-off-by: Hailong Cui <ihailong@amazon.com> * home dashboards/listing page only show public workspace data Signed-off-by: Hailong Cui <ihailong@amazon.com> * Add more test case Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> * fix empty workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
ruanyl
pushed a commit
that referenced
this pull request
May 17, 2024
…ensearch-project#6458) (opensearch-project#6580) * Add workspace filter into saved objects page (#211) * Add workspace column/filter into saved objects page Signed-off-by: Hailong Cui <ihailong@amazon.com> fix failed test case Signed-off-by: Hailong Cui <ihailong@amazon.com> move workspace column to its own folder Signed-off-by: Hailong Cui <ihailong@amazon.com> * default workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> fix test case Signed-off-by: Hailong Cui <ihailong@amazon.com> add test case Signed-off-by: Hailong Cui <ihailong@amazon.com> remove hide import Signed-off-by: Hailong Cui <ihailong@amazon.com> * address review comments Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> * replace default workspace with public workspace (#322) Signed-off-by: Hailong Cui <ihailong@amazon.com> * Add workspace filter Signed-off-by: Hailong Cui <ihailong@amazon.com> * revert query params change Signed-off-by: Hailong Cui <ihailong@amazon.com> * udpate test case name to more clear Signed-off-by: Hailong Cui <ihailong@amazon.com> * support public workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * Add changelog Signed-off-by: Hailong Cui <ihailong@amazon.com> * update fetchExportByTypeAndSearch parameter Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove virtrual public workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * update comments Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix public workspace query when permission is not enabled Signed-off-by: Hailong Cui <ihailong@amazon.com> * home dashboards/listing page only show public workspace data Signed-off-by: Hailong Cui <ihailong@amazon.com> * Add more test case Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit 9408e49) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace default workspace with public workspace, public workspace has parity with global tenant in 2.15.
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration