Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace list card on home #336

Conversation

Hailong-am
Copy link
Collaborator

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Hailong Cui <ihailong@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 65.51724% with 20 lines in your changes missing coverage. Please review.

Please upload report for BASE (new-core-plugin-to-dynamic-content-rendering@92fc98d). Learn more about missing BASE report.

Files Patch % Lines
...ic/components/service_card/workspace_list_card.tsx 67.56% 8 Missing and 4 partials ⚠️
src/plugins/workspace/public/plugin.ts 14.28% 6 Missing ⚠️
...ugins/workspace/public/recent_workspace_manager.ts 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                               Coverage Diff                               @@
##             new-core-plugin-to-dynamic-content-rendering     #336   +/-   ##
===============================================================================
  Coverage                                                ?   67.62%           
===============================================================================
  Files                                                   ?     3518           
  Lines                                                   ?    69602           
  Branches                                                ?    11360           
===============================================================================
  Hits                                                    ?    47070           
  Misses                                                  ?    19747           
  Partials                                                ?     2785           
Flag Coverage Δ
Linux_2 55.46% <ø> (?)
Linux_3 43.32% <ø> (?)
Linux_4 34.69% <ø> (?)
Windows_1 33.16% <65.51%> (?)
Windows_2 55.41% <ø> (?)
Windows_3 43.32% <ø> (?)
Windows_4 34.69% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hailong-am Hailong-am closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants