feat: make workspace request go through permission check #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
add license header Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
workspace template init commit
Add interfaces and partial implement for public core.workspaces
Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
…ment Workspace service implement
* feat: add workspace creator page Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: integrate with application workspace template Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add max-width and remove image wrapper if not exists Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: update filter condition to align with collapsible nav Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com>
* fix: validation & query Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: modify file name to reduce confusion Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: add landing logic to retrive workspace id Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: add worklist observable Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: add worklist observable Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: add worklist observable Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * fix: type error Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * fix: type error Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: make client more robust Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: use Subject Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
* feat: integrate with workspace create API Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: update to i18n text for toast Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com>
* feat: add currentWorkspace$ Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * fix: type error Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: add emit on currentWorkspace$ Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Add workspace dropdown list --------- Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> Signed-off-by: suzhou <suzhou@amazon.com> Co-authored-by: SuZhoue-Joe <suzhou@amazon.com>
* feat: init workspace menu stage 1 Signed-off-by: tygao <tygao@amazon.com> * fix: remove port diff Signed-off-by: tygao <tygao@amazon.com> * feat: update menu logic Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com>
* fix import error Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix osd bootstrap failure Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>
* feat: add workspace overview page Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: move paths to common constants Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add workspace overview item by custom nav in start phase Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: change to currentWorkspace$ in workspace client Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com>
…rch-project#23) Signed-off-by: Lin Wang <wonglam@amazon.com>
* feat: update workspace switch Signed-off-by: tygao <tygao@amazon.com> * fix: fix switch error Signed-off-by: tygao <tygao@amazon.com> * fix: fix prettier after merge Signed-off-by: tygao <tygao@amazon.com> * chore: remove extra code after merge Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: gaobinlong <gbinlong@amazon.com>
* add delete workspace modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * implement delete on workspace overview page Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix export on delete workspace modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add try catch to handle errors for workspace delete Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move visibility control to workspace overview page exlusively Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove unused import Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com>
…oject#26) Signed-off-by: Lin Wang <wonglam@amazon.com>
* feat: update menu logic Signed-off-by: tygao <tygao@amazon.com> * fix: use navLinks to filter Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com>
…search-project#29) Signed-off-by: Lin Wang <wonglam@amazon.com>
* temp: save Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: make create/find support workspaces Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: extract management code Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * fix: type check Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * fix: build error Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: enable workspaces on saved client server side Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: some optimization Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: extract management code Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: merge fix Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: reuse common function Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: optimize code when create Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: remove useless test code Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
* add delete workspace modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * implement delete on workspace overview page Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix export on delete workspace modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add try catch to handle errors for workspace delete Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move visibility control to workspace overview page exlusively Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove unused import Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change workspace overview route to workspace update Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move delete button from workspace overview page to update page Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove update button from workspace overview page Signed-off-by: yuye-aws <yuyezhu@amazon.com> * recover router to workspace overview page Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change navigation url for workspace overview button on left side panel Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
* remove duplicate EuiPage Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix: remove duplicate workspace template Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>
…ct#33) Signed-off-by: zhichao-aws <zhichaog@amazon.com>
this is a temporary fix just for demo, should be reverted later Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
…t#32) * feat: add some logic check when overwrite a saved object Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * fix: type check Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
) * feat: add color, icon and defaultVISTheme field for workspace saved object Signed-off-by: Lin Wang <wonglam@amazon.com> * add new fields to workspace form Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: remove feature or group name hack Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
* feat: register library menus Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: some update Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
* Exit workspace from left menu Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Show exit workspace button with small window size Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Remove recently viewed and workspace overview on left menu Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Add buttons for outside, inside workspace case Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Implement home button and workspace over view button on left menu Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Implement workspace dropdown list in left menu Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Add props on recently accessed and custom nav link Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Add three props to mock props for collapsible nav: exitWorkspace, getWorkspaceUrl, workspaceList$ Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Add three props to mock props for header: exitWorkspace, getWorkspaceUrl, workspaceList$ Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Fix bugs for function createWorkspaceNavLink Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Remove unused constants Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Reuse method getWorkspaceUrl Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Remove recently accessed and custom nav props in test Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Revert "Remove recently accessed and custom nav props in test" This reverts commit 7895e5c. * Wrap title with i18n Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Add redirect for workspace app Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Enable users to go to workspace lists page via see more under workspaces in left menu Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com>
* feat: make url stateful Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: remove useless change Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: optimize url listener Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: make formatUrlWithWorkspaceId extensible Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: modify to related components Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: modify the async format to be sync function Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: modify the async format to be sync function Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * fix: type check Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> * feat: use path to maintain workspace info Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhoue-Joe <suzhou@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
* fix: fix build error and some ut Signed-off-by: tygao <tygao@amazon.com> * chore: remove saved object client test diff Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
* feat: add workspace permission control interface Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add request parameter for workspace permission control Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Codecov Report
@@ Coverage Diff @@
## workspace #48 +/- ##
=============================================
- Coverage 66.11% 66.11% -0.01%
=============================================
Files 3243 3244 +1
Lines 62463 62475 +12
Branches 9688 9691 +3
=============================================
+ Hits 41299 41304 +5
- Misses 18811 18819 +8
+ Partials 2353 2352 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr