Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor navigation links from left menu hard code to workspace plugin register #54

Closed
wants to merge 48 commits into from

Conversation

yuye-aws
Copy link
Collaborator

@yuye-aws yuye-aws commented Jul 18, 2023

Description

  1. Check whether workspace is enabled for left menu.
  2. Refactor to move workspace related nav link from left menu hardcode to workspace plugin.
  3. Move exit workspace button from left menu to workspace update page.
  4. Add nav links: "Home", "See more", "Overview" and "Admin" to the left menu.
  5. Recover recently viewed items for the left menu.

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yuye-aws yuye-aws changed the title Refactor "outside workspace" menus from hard code in chrome_service.tsx to register from plugins. Refactor hard code navigation links from hard code to plugins Jul 18, 2023
@yuye-aws yuye-aws changed the title Refactor hard code navigation links from hard code to plugins Refactor hard code navigation links from left menu to plugins Jul 18, 2023
@yuye-aws yuye-aws changed the title Refactor hard code navigation links from left menu to plugins Refactor navigation links from hard code in left menu to register in plugins Jul 18, 2023
@yuye-aws yuye-aws changed the title Refactor navigation links from hard code in left menu to register in plugins Refactor navigation links from left menu hard code to workspace plugin register Jul 18, 2023
@yuye-aws yuye-aws requested review from ruanyl, raintygao and Hailong-am and removed request for ruanyl and raintygao July 18, 2023 22:50
@wanglam
Copy link
Collaborator

wanglam commented Jul 19, 2023

@yuye-aws Since there are too many conflicts, could you resolve these conflicts first?

@yuye-aws
Copy link
Collaborator Author

@yuye-aws Since there are too many conflicts, could you resolve these conflicts first?

Ok, I am resolving the conflicts now.

SuZhou-Joe and others added 14 commits July 19, 2023 15:59
Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
…Url, workspaceList$

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
yuye-aws and others added 27 commits July 19, 2023 16:18
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Merging #54 (2187b0a) into workspace (05fd6f6) will increase coverage by 0.05%.
The diff coverage is 42.30%.

@@              Coverage Diff              @@
##           workspace      #54      +/-   ##
=============================================
+ Coverage      65.91%   65.96%   +0.05%     
=============================================
  Files           3329     3329              
  Lines          64224    64201      -23     
  Branches       10024    10014      -10     
=============================================
+ Hits           42335    42352      +17     
+ Misses         19427    19384      -43     
- Partials        2462     2465       +3     
Flag Coverage Δ
Linux_1 ?
Linux_3 ?
Linux_4 ?
Windows_1 34.70% <3.84%> (+0.02%) ⬆️
Windows_2 54.67% <41.17%> (+0.17%) ⬆️
Windows_3 42.92% <1.96%> (+0.02%) ⬆️
Windows_4 34.92% <1.96%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/public/chrome/chrome_service.mock.ts 100.00% <ø> (ø)
src/core/public/chrome/chrome_service.tsx 91.66% <ø> (+10.71%) ⬆️
src/core/public/chrome/constants.ts 100.00% <ø> (ø)
src/core/public/chrome/nav_links/nav_link.ts 66.66% <ø> (ø)
src/core/public/chrome/ui/header/header.tsx 75.00% <ø> (ø)
src/core/public/chrome/ui/header/nav_link.tsx 50.00% <0.00%> (+46.77%) ⬆️
src/core/public/core_system.ts 91.86% <ø> (ø)
...e/public/fatal_errors/fatal_errors_service.mock.ts 100.00% <ø> (ø)
src/core/public/workspace/workspaces_service.ts 27.27% <ø> (ø)
src/core/public/workspace/workspaces_client.ts 18.75% <16.66%> (+3.88%) ⬆️
... and 3 more

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yuye-aws yuye-aws closed this Jul 19, 2023
@yuye-aws yuye-aws deleted the workspace branch July 24, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants