Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor navigation links from left menu hard code to workspace plugin register #54

Closed
wants to merge 48 commits into from
Closed

Refactor navigation links from left menu hard code to workspace plugin register #54

wants to merge 48 commits into from

Commits on Jul 19, 2023

  1. feature: add public/workspaces service 

    Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
    @SuZhou-Joe @yuye-aws
    SuZhou-Joe authored and yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    7d08b20 View commit details
    Browse the repository at this point in the history

  2. merge conflicts 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    339b58e View commit details
    Browse the repository at this point in the history

  3. Show exit workspace button with small window size 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    fa43a53 View commit details
    Browse the repository at this point in the history

  4. Remove recently viewed and workspace overview on left menu 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    daf6269 View commit details
    Browse the repository at this point in the history

  5. Add buttons for outside, inside workspace case 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    b8b8888 View commit details
    Browse the repository at this point in the history

  6. Implement home button and workspace over view button on left menu 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    bbdb317 View commit details
    Browse the repository at this point in the history

  7. Implement workspace dropdown list in left menu 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    8fc322b View commit details
    Browse the repository at this point in the history

  8. Add props on recently accessed and custom nav link 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    533ab05 View commit details
    Browse the repository at this point in the history

  9. Add three props to mock props for header: exitWorkspace, getWorkspace… 

    …Url, workspaceList$

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    7d6b40f View commit details
    Browse the repository at this point in the history

  10. Fix bugs for function createWorkspaceNavLink 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    97033fd View commit details
    Browse the repository at this point in the history

  11. Remove unused constants 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    47b7e18 View commit details
    Browse the repository at this point in the history

  12. Reuse method getWorkspaceUrl 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    3b2b5a9 View commit details
    Browse the repository at this point in the history

  13. Remove recently accessed and custom nav props in test 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    630116a View commit details
    Browse the repository at this point in the history

  14. Revert "Remove recently accessed and custom nav props in test" 

    This reverts commit 7895e5c.
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    a6b29f4 View commit details
    Browse the repository at this point in the history

  15. Wrap title with i18n 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    2e4117a View commit details
    Browse the repository at this point in the history

  16. Add redirect for workspace app 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    aa57fcc View commit details
    Browse the repository at this point in the history

  17. Enable users to go to workspace lists page via see more under workspa… 

    …ces in left menu

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    258b1e0 View commit details
    Browse the repository at this point in the history

  18. Feature/menu change (#37) 

    * feat: register library menus

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

* feat: some update

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>

* feat: optimize code

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimize code

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhoue-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
    @SuZhou-Joe @yuye-aws
    SuZhou-Joe authored and yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    5427669 View commit details
    Browse the repository at this point in the history

  19. Comment Alerts and Favorites in left menu 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    e99cdb0 View commit details
    Browse the repository at this point in the history

  20. Recover recently viewed items in left menu 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    502da73 View commit details
    Browse the repository at this point in the history

  21. Move exit workspace from left menu to update page 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    e6ae4ca View commit details
    Browse the repository at this point in the history

  22. Remove unused import 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    44b2978 View commit details
    Browse the repository at this point in the history

  23. Add workspace category info 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    1d0288c View commit details
    Browse the repository at this point in the history

  24. Remove workspace nav link 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    45ddf55 View commit details
    Browse the repository at this point in the history

  25. Remove unused import 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    16b1c77 View commit details
    Browse the repository at this point in the history

  26. Add FilteredNavLinks props to chrome service mock 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    3642f70 View commit details
    Browse the repository at this point in the history

  27. Remove workspace related constans from chrome 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    0ed390b View commit details
    Browse the repository at this point in the history

  28. Remove workspace related props from chrome and core 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    996ad88 View commit details
    Browse the repository at this point in the history

  29. Remove workspace related props from header 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    fb384d2 View commit details
    Browse the repository at this point in the history

  30. Shorten import path for workspace updater 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    067a181 View commit details
    Browse the repository at this point in the history

  31. Add euiIconType for workspace left menu category 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    b63faed View commit details
    Browse the repository at this point in the history

  32. Remove workspace related props for collapsible nav 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    82dee54 View commit details
    Browse the repository at this point in the history

  33. Remove workspace related props for collapsible nav 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    a078109 View commit details
    Browse the repository at this point in the history

  34. Implement navigation for delete and exit workspace 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    02da4bd View commit details
    Browse the repository at this point in the history

  35. Navigate external links through url change 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    8de852e View commit details
    Browse the repository at this point in the history

  36. Implement filteredNavLinks and sort ChromeNavLinks in nav link service 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    05ccf67 View commit details
    Browse the repository at this point in the history

  37. Add workspace list, see more, admin and overview into chromenavlinks 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    6227335 View commit details
    Browse the repository at this point in the history

  38. fix: unit test failure (#50) 

    Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
    @SuZhou-Joe @yuye-aws
    SuZhou-Joe authored and yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    fb25b85 View commit details
    Browse the repository at this point in the history

  39. Resolve conflicts 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    73f435c View commit details
    Browse the repository at this point in the history

  40. Fix osd bootstrap error 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    9f5bf12 View commit details
    Browse the repository at this point in the history

  41. Check workspace enabled for left menu 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    f65331e View commit details
    Browse the repository at this point in the history

  42. Add home nav link to left menu when outside workspace 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    73543c9 View commit details
    Browse the repository at this point in the history

  43. Fix unit test for collapsible nav 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    464dfdb View commit details
    Browse the repository at this point in the history

  44. Fix unit test for header 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    9673e06 View commit details
    Browse the repository at this point in the history

  45. Fix unit test for collapsible nav 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    3ec8c7b View commit details
    Browse the repository at this point in the history

  46. Fix unit test for collapsible nav 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    1f12e35 View commit details
    Browse the repository at this point in the history

  47. Update snapshot for unit tests 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    31c2c9a View commit details
    Browse the repository at this point in the history

  48. fix bug in core 

    Signed-off-by: yuye-aws <yuyezhu@amazon.com>
    @yuye-aws
    yuye-aws committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    2187b0a View commit details
    Browse the repository at this point in the history