Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply workspace permission check when saving object #59

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

raintygao
Copy link
Collaborator

Description

Apply workspace permission check when saving object

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Merging #59 (6255127) into workspace (210d3c5) will decrease coverage by 15.62%.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##           workspace      #59       +/-   ##
==============================================
- Coverage      65.86%   50.24%   -15.62%     
==============================================
  Files           3337     2522      -815     
  Lines          64339    48922    -15417     
  Branches       10043     7471     -2572     
==============================================
- Hits           42374    24582    -17792     
- Misses         19472    23158     +3686     
+ Partials        2493     1182     -1311     
Flag Coverage Δ
Linux_1 34.71% <ø> (+0.01%) ⬆️
Linux_3 ?
Windows_1 ?
Windows_2 54.54% <0.00%> (-0.03%) ⬇️
Windows_3 ?
Windows_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._objects/workspace_saved_objects_client_wrapper.ts 4.91% <0.00%> (-1.09%) ⬇️

... and 1424 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@raintygao raintygao merged commit e69a1f3 into ruanyl:workspace Jul 25, 2023
45 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants