Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acl permission related functions #65

Merged
merged 9 commits into from
Aug 3, 2023

Conversation

gaobinlong
Copy link
Collaborator

@gaobinlong gaobinlong commented Jul 28, 2023

Description

The main changes of this PR are:

  1. Add 4 acl permission related functions: hasPermission, addPermission, removePermission, genereateGetPermittedSavedObjectsQueryDSL.
  2. Add some unit tests for the above functions.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: gaobinlong <gbinlong@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Merging #65 (db26b2b) into workspace (5337ad7) will decrease coverage by 31.15%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           workspace      #65       +/-   ##
==============================================
- Coverage      65.85%   34.71%   -31.15%     
==============================================
  Files           3341     1923     -1418     
  Lines          64386    38189    -26197     
  Branches       10050     5458     -4592     
==============================================
- Hits           42402    13256    -29146     
- Misses         19489    24326     +4837     
+ Partials        2495      607     -1888     
Flag Coverage Δ
Linux_1 ?
Linux_3 ?
Windows_1 34.71% <ø> (ø)
Windows_2 ?
Windows_3 ?
Windows_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/core/utils/constants.ts 100.00% <ø> (ø)

... and 2154 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: gaobinlong <gbinlong@amazon.com>
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Signed-off-by: gaobinlong <gbinlong@amazon.com>
@Hailong-am Hailong-am merged commit 69d7e65 into ruanyl:workspace Aug 3, 2023
40 of 43 checks passed
ruanyl pushed a commit that referenced this pull request Aug 3, 2023
* Add acl permission check functions

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Refactor some code

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Optimize some code

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Refactor acl

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Modify index mapping definition code

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Optimize code

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Optimize code

Signed-off-by: gaobinlong <gbinlong@amazon.com>

---------

Signed-off-by: gaobinlong <gbinlong@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 31, 2023
* Add acl permission check functions

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Refactor some code

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Optimize some code

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Refactor acl

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Modify index mapping definition code

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Optimize code

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Optimize code

Signed-off-by: gaobinlong <gbinlong@amazon.com>

---------

Signed-off-by: gaobinlong <gbinlong@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 31, 2023
* Add acl permission check functions

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Refactor some code

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Optimize some code

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Refactor acl

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Modify index mapping definition code

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Optimize code

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Optimize code

Signed-off-by: gaobinlong <gbinlong@amazon.com>

---------

Signed-off-by: gaobinlong <gbinlong@amazon.com>
ruanyl pushed a commit that referenced this pull request Sep 15, 2023
* Add acl permission check functions

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Refactor some code

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Optimize some code

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Refactor acl

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Modify index mapping definition code

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Optimize code

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Optimize code

Signed-off-by: gaobinlong <gbinlong@amazon.com>

---------

Signed-off-by: gaobinlong <gbinlong@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants