Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acl permission related functions #65

Merged
merged 9 commits into from
Aug 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import crypto from 'crypto';
import { cloneDeep, mapValues } from 'lodash';
import {
IndexMapping,
SavedObjectsFieldMapping,
SavedObjectsMappingProperties,
SavedObjectsTypeMappingDefinitions,
} from './../../mappings';
Expand Down Expand Up @@ -137,6 +138,16 @@ function findChangedProp(actual: any, expected: any) {
* @returns {IndexMapping}
*/
function defaultMapping(): IndexMapping {
const principals: SavedObjectsFieldMapping = {
properties: {
users: {
type: 'keyword',
},
groups: {
type: 'keyword',
},
},
};
return {
dynamic: 'strict',
properties: {
Expand Down Expand Up @@ -178,6 +189,15 @@ function defaultMapping(): IndexMapping {
workspaces: {
type: 'keyword',
},
permissions: {
properties: {
read: principals,
write: principals,
management: principals,
library_read: principals,
library_write: principals,
},
},
},
};
}
Expand Down
164 changes: 164 additions & 0 deletions src/core/server/saved_objects/permission_control/acl.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,164 @@
/*
* Copyright OpenSearch Contributors
* SPDX-License-Identifier: Apache-2.0
*/

import { PermissionMode } from '../../../../core/utils/constants';
import { Principals, Permissions, ACL } from './acl';

describe('SavedObjectTypeRegistry', () => {
let acl: ACL;

it('test has permission', () => {
const principals: Principals = {
users: ['user1'],
groups: [],
};
const permissions: Permissions = {
read: principals,
};
acl = new ACL(permissions);
expect(
acl.hasPermission([PermissionMode.Read], {
users: ['user1'],
groups: [],
})
).toEqual(true);
expect(
acl.hasPermission([PermissionMode.Read], {
users: ['user2'],
groups: [],
})
).toEqual(false);
});

it('test add permission', () => {
acl = new ACL();
const result1 = acl
.addPermission([PermissionMode.Read], {
users: ['user1'],
groups: [],
})
.getPermissions();
expect(result1?.read?.users).toEqual(['user1']);

acl.resetPermissions();
const result2 = acl
.addPermission([PermissionMode.Write, PermissionMode.Management], {
users: ['user2'],
groups: ['group1', 'group2'],
})
.getPermissions();
expect(result2?.write?.users).toEqual(['user2']);
expect(result2?.management?.groups).toEqual(['group1', 'group2']);
});

it('test remove permission', () => {
const principals1: Principals = {
users: ['user1'],
groups: ['group1', 'group2'],
};
const permissions1 = {
read: principals1,
write: principals1,
};
acl = new ACL(permissions1);
const result1 = acl
.removePermission([PermissionMode.Read], {
users: ['user1'],
groups: [],
})
.removePermission([PermissionMode.Write], {
users: [],
groups: ['group2'],
})
.getPermissions();
expect(result1?.read?.users).toEqual([]);
expect(result1?.write?.groups).toEqual(['group1']);

const principals2: Principals = {
users: ['*'],
groups: ['*'],
};

const permissions2 = {
read: principals2,
write: principals2,
};

acl = new ACL(permissions2);
const result2 = acl
.removePermission([PermissionMode.Read, PermissionMode.Write], {
users: ['user1'],
groups: ['group1'],
})
.getPermissions();
expect(result2?.read?.users).toEqual(['*']);
expect(result2?.write?.groups).toEqual(['*']);
});

it('test transform permission', () => {
const principals: Principals = {
users: ['user1'],
groups: ['group1', 'group2'],
};
const permissions = {
read: principals,
write: principals,
};
acl = new ACL(permissions);
const result = acl.transformPermissions();
expect(result?.length).toEqual(3);
});

it('test genereate query DSL', () => {
const principals = {
users: ['user1'],
groups: ['group1'],
};
const result = ACL.genereateGetPermittedSavedObjectsQueryDSL(
PermissionMode.Read,
principals,
'workspace'
);
expect(result).toEqual({
query: {
bool: {
filter: [
{
bool: {
should: [
{
terms: {
'permissions.read.users': ['user1'],
},
},
{
term: {
'permissions.read.users': '*',
},
},
{
terms: {
'permissions.read.groups': ['group1'],
},
},
{
term: {
'permissions.read.groups': '*',
},
},
],
},
},
{
terms: {
type: ['workspace'],
},
},
],
},
},
});
});
});
Loading
Loading