apply workspace permission check when bulk creating object #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## workspace #66 +/- ##
=============================================
+ Coverage 65.85% 65.86% +0.01%
=============================================
Files 3341 3341
Lines 64386 64388 +2
Branches 10050 10051 +1
=============================================
+ Hits 42402 42412 +10
- Misses 19489 19509 +20
+ Partials 2495 2467 -28
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wanglam
reviewed
Jul 28, 2023
| @@ -96,6 +96,16 @@ export class WorkspaceSavedObjectsClientWrapper { | |||
| objects: Array<SavedObjectsBulkCreateObject<T>>, | |||
| options: SavedObjectsCreateOptions = {} | |||
| ): Promise<SavedObjectsBulkResponse<T>> => { | |||
| if (options.workspaces) { | |||
| options.workspaces = options.workspaces.filter( | |||
There was a problem hiding this comment.
Is that means the bulkCreate operation will be continued if user don't have permission to any one workspace? The options.workspaces will be empty, based current logic.
SuZhou-Joe
reviewed
Aug 2, 2023
| async (workspaceId) => | ||
| await this.permissionControl.validate( | ||
| workspaceId, | ||
| WorkspacePermissionMode.Admin, |
There was a problem hiding this comment.
Suggested change
| WorkspacePermissionMode.Admin, | |
| [WorkspacePermissionMode.Write, WorkspacePermissionMode.Management], |
Should be like this I think? Please rebase the latest code from workspace, the enum and validate function has some changes.
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
raintygao
force-pushed
the
feat-bulk-create
branch
from
01e21a2
to
b4a004f
Compare
Hailong-am
approved these changes
Aug 2, 2023
wanglam
approved these changes
Aug 2, 2023
ruanyl
pushed a commit
that referenced
this pull request
Aug 3, 2023
* feat: Apply workspace permission check when bulk creating object Signed-off-by: tygao <tygao@amazon.com> * chore: update bulk create function Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 31, 2023
* feat: Apply workspace permission check when bulk creating object Signed-off-by: tygao <tygao@amazon.com> * chore: update bulk create function Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 31, 2023
* feat: Apply workspace permission check when bulk creating object Signed-off-by: tygao <tygao@amazon.com> * chore: update bulk create function Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com>
ruanyl
pushed a commit
that referenced
this pull request
Sep 15, 2023
* feat: Apply workspace permission check when bulk creating object Signed-off-by: tygao <tygao@amazon.com> * chore: update bulk create function Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
apply workspace permission check when bulk creating object
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr