share saved objects to workspace api #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## workspace #67 +/- ##
=============================================
- Coverage 65.84% 65.77% -0.07%
=============================================
Files 3339 3340 +1
Lines 64368 64442 +74
Branches 10048 10066 +18
=============================================
+ Hits 42382 42387 +5
- Misses 19491 19559 +68
- Partials 2495 2496 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
SuZhou-Joe
reviewed
Jul 31, 2023
wanglam
reviewed
Jul 31, 2023
src/core/server/workspaces/saved_objects/workspace_saved_objects_client_wrapper.ts
Show resolved
Hide resolved
Hailong-am
force-pushed
the
feature/saved_object_share_api
branch
from
cc79490
to
f4eb765
Compare
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
force-pushed
the
feature/saved_object_share_api
branch
from
cde9a8a
to
713463d
Compare
wanglam
approved these changes
Aug 3, 2023
ruanyl
pushed a commit
that referenced
this pull request
Aug 3, 2023
* share saved objects to workspace api Signed-off-by: Hailong Cui <ihailong@amazon.com> * using script for bulk update Signed-off-by: Hailong Cui <ihailong@amazon.com> * filter out pulbic saved objects when sharing Signed-off-by: Hailong Cui <ihailong@amazon.com> * refactor saved object permission error Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix merge issue Signed-off-by: Hailong Cui <ihailong@amazon.com> * permission check for target workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * move source workspace existence validation to repository Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 31, 2023
* share saved objects to workspace api Signed-off-by: Hailong Cui <ihailong@amazon.com> * using script for bulk update Signed-off-by: Hailong Cui <ihailong@amazon.com> * filter out pulbic saved objects when sharing Signed-off-by: Hailong Cui <ihailong@amazon.com> * refactor saved object permission error Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix merge issue Signed-off-by: Hailong Cui <ihailong@amazon.com> * permission check for target workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * move source workspace existence validation to repository Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 31, 2023
* share saved objects to workspace api Signed-off-by: Hailong Cui <ihailong@amazon.com> * using script for bulk update Signed-off-by: Hailong Cui <ihailong@amazon.com> * filter out pulbic saved objects when sharing Signed-off-by: Hailong Cui <ihailong@amazon.com> * refactor saved object permission error Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix merge issue Signed-off-by: Hailong Cui <ihailong@amazon.com> * permission check for target workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * move source workspace existence validation to repository Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>
ruanyl
pushed a commit
that referenced
this pull request
Sep 15, 2023
* share saved objects to workspace api Signed-off-by: Hailong Cui <ihailong@amazon.com> * using script for bulk update Signed-off-by: Hailong Cui <ihailong@amazon.com> * filter out pulbic saved objects when sharing Signed-off-by: Hailong Cui <ihailong@amazon.com> * refactor saved object permission error Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix merge issue Signed-off-by: Hailong Cui <ihailong@amazon.com> * permission check for target workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * move source workspace existence validation to repository Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
saved objects share api
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr