Remove server side workspace feature flag check #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is due to error when retrieving uiSettings in registerOnPreRouting which request is still unauthenticated Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe
approved these changes
Aug 1, 2023
Codecov Report
@@ Coverage Diff @@
## workspace #69 +/- ##
=============================================
- Coverage 65.85% 65.83% -0.02%
=============================================
Files 3341 3341
Lines 64393 64386 -7
Branches 10052 10050 -2
=============================================
- Hits 42403 42389 -14
+ Misses 19595 19500 -95
- Partials 2395 2497 +102
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 23 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ruanyl
added a commit
that referenced
this pull request
Aug 3, 2023
stop checking workspace feature flag in server side This is due to error when retrieving uiSettings in registerOnPreRouting which request is still unauthenticated --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 31, 2023
stop checking workspace feature flag in server side This is due to error when retrieving uiSettings in registerOnPreRouting which request is still unauthenticated --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 31, 2023
stop checking workspace feature flag in server side This is due to error when retrieving uiSettings in registerOnPreRouting which request is still unauthenticated --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
ruanyl
added a commit
that referenced
this pull request
Sep 15, 2023
stop checking workspace feature flag in server side This is due to error when retrieving uiSettings in registerOnPreRouting which request is still unauthenticated --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed server side check of workspace feature flag
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr