Change public objects logic & Search with ACL control #71

SuZhou-Joe · 2023-08-02T10:52:54Z

Description

Issues Resolved

Screenshot

Testing the changes

Check List

codecov-commenter · 2023-08-02T15:07:21Z

Codecov Report

Merging #71 (19f1313) into workspace (06e37a3) will decrease coverage by 23.26%.
Report is 2 commits behind head on workspace.
The diff coverage is 8.10%.

❗ Current head 19f1313 differs from pull request most recent head 47f8bd5. Consider uploading reports for the commit 47f8bd5 to get more accurate results

@@              Coverage Diff               @@
##           workspace      #71       +/-   ##
==============================================
- Coverage      65.64%   42.39%   -23.26%     
==============================================
  Files           3341     1604     -1737     
  Lines          64599    32541    -32058     
  Branches       10277     6103     -4174     
==============================================
- Hits           42409    13795    -28614     
+ Misses         19653    17704     -1949     
+ Partials        2537     1042     -1495

Flag	Coverage Δ
Linux_3	`42.39% <8.10%> (-0.02%)`	⬇️
Windows_1	`?`
Windows_2	`?`
Windows_3	`?`
Windows_4	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
.../core/public/saved_objects/saved_objects_client.ts	`4.54% <0.00%> (-84.78%)`	⬇️
src/core/public/workspace/workspaces_service.ts	`0.00% <0.00%> (-27.28%)`	⬇️
src/core/server/saved_objects/routes/share.ts	`8.33% <ø> (-4.17%)`	⬇️
...ore/server/saved_objects/service/lib/repository.ts	`1.37% <ø> (-82.32%)`	⬇️
...ved_objects/service/lib/search_dsl/query_params.ts	`5.26% <ø> (-75.15%)`	⬇️
...rver/saved_objects/service/saved_objects_client.ts	`3.84% <ø> (-53.85%)`	⬇️
src/core/server/server.ts	`2.15% <0.00%> (-96.78%)`	⬇️
src/core/server/ui_settings/settings/workspace.ts	`50.00% <ø> (-50.00%)`	⬇️
src/core/server/workspaces/constants.ts	`100.00% <ø> (ø)`
..._objects/workspace_saved_objects_client_wrapper.ts	`3.94% <0.00%> (-1.39%)`	⬇️
... and 2 more

... and 2285 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/core/server/workspaces/saved_objects/workspace_saved_objects_client_wrapper.ts

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

src/core/server/workspaces/saved_objects/workspace_saved_objects_client_wrapper.ts

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

src/core/public/saved_objects/saved_objects_client.ts

src/plugins/workspace/public/plugin.ts

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

ruanyl · 2023-08-09T09:57:53Z

src/core/public/workspace/workspaces_client.ts

@@ -70,6 +70,8 @@ export class WorkspacesClient {
        }
      }
    );
+
+    this.init();


I originally moved the calling of init() to workspace plugin setup() function so it only calls init() when workspace is enabled. Any reason to move it to constructor()?

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update public workspace Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * refractor: change public objects logic Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: create public workspace when service start Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some modify Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feature: some optimize and create workspace when ui settings is open Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * temp: submit Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update query dsl Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: use same constants Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: make it run Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove dashboard admin Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: modify query DSL Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: modify query DSL Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: modify query DSL Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: list principals route Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize query DSL Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change public logic Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove init Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add judgement when workspaceList is empty Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe changed the base branch from main to workspace August 2, 2023 10:53

github-actions bot added the seasoned-contributor label Aug 2, 2023

SuZhou-Joe marked this pull request as draft August 3, 2023 03:04

SuZhou-Joe force-pushed the feature/public_logic_refractor branch from c61ebcd to 4223a02 Compare August 3, 2023 03:16

ruanyl reviewed Aug 3, 2023

View reviewed changes

src/core/server/workspaces/saved_objects/workspace_saved_objects_client_wrapper.ts Outdated Show resolved Hide resolved

SuZhou-Joe added the Skip-Changelog label Aug 3, 2023

SuZhou-Joe force-pushed the feature/public_logic_refractor branch from 990196a to 380a008 Compare August 3, 2023 08:10

ruanyl force-pushed the workspace branch from fe45431 to 8bacb1b Compare August 3, 2023 09:26

SuZhou-Joe force-pushed the feature/public_logic_refractor branch 2 times, most recently from 5dcf2f9 to e1fee65 Compare August 7, 2023 10:55

SuZhou-Joe marked this pull request as ready for review August 7, 2023 10:55

SuZhou-Joe force-pushed the feature/public_logic_refractor branch from 03006fe to 0f4d73d Compare August 8, 2023 05:59

SuZhou-Joe commented Aug 9, 2023

View reviewed changes

src/core/server/workspaces/saved_objects/workspace_saved_objects_client_wrapper.ts Show resolved Hide resolved

SuZhou-Joe force-pushed the feature/public_logic_refractor branch from 0307540 to 168b747 Compare August 9, 2023 05:37

SuZhou-Joe changed the title ~~Change public objects logic~~ Change public objects logic & Search with ACL control Aug 9, 2023

SuZhou-Joe added 14 commits August 9, 2023 14:48

feat: update public workspace

3cfdc38

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

refractor: change public objects logic

8f3b29f

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: create public workspace when service start

e09a887

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: some modify

93885d8

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feature: some optimize and create workspace when ui settings is open

e20d6ea

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: update

f1c4ed5

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: update

e9bf305

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: update

e9c9a4e

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: update

15ff5db

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

temp: submit

59c01f9

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: update

6648bd0

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: update

6cd39d4

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: update

a8ed9d3

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: update

bb65ed5

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe added 7 commits August 9, 2023 14:51

feat: update query dsl

5c2634a

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: use same constants

ecc4b57

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: make it run

c487141

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: remove dashboard admin

1b2bf54

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: modify query DSL

59c0c9f

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: modify query DSL

ffbf2c4

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: modify query DSL

dbd7f8f

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe force-pushed the feature/public_logic_refractor branch from 21d2da4 to dbd7f8f Compare August 9, 2023 06:51

gaobinlong reviewed Aug 9, 2023

View reviewed changes

src/core/server/workspaces/saved_objects/workspace_saved_objects_client_wrapper.ts Outdated Show resolved Hide resolved

gaobinlong reviewed Aug 9, 2023

View reviewed changes

src/core/server/workspaces/saved_objects/workspace_saved_objects_client_wrapper.ts Outdated Show resolved Hide resolved

SuZhou-Joe added 2 commits August 9, 2023 15:11

feat: list principals route

3217788

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: optimize query DSL

a93c2ac

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

ruanyl reviewed Aug 9, 2023

View reviewed changes

src/core/public/saved_objects/saved_objects_client.ts Outdated Show resolved Hide resolved

src/plugins/workspace/public/plugin.ts Outdated Show resolved Hide resolved

src/plugins/workspace/public/plugin.ts Outdated Show resolved Hide resolved

SuZhou-Joe added 2 commits August 9, 2023 17:44

feat: change public logic

47f8bd5

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: update

8375910

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

ruanyl reviewed Aug 9, 2023

View reviewed changes

SuZhou-Joe added 2 commits August 9, 2023 17:59

feat: update

0c53ece

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: remove init

2579883

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

ruanyl approved these changes Aug 9, 2023

View reviewed changes

feat: add judgement when workspaceList is empty

384449d

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe merged commit 23a77e9 into ruanyl:workspace Aug 9, 2023
36 of 39 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change public objects logic & Search with ACL control #71

Change public objects logic & Search with ACL control #71

SuZhou-Joe commented Aug 2, 2023 •

edited

Loading

codecov-commenter commented Aug 2, 2023 •

edited

Loading

ruanyl Aug 9, 2023

Change public objects logic & Search with ACL control #71

Change public objects logic & Search with ACL control #71

Conversation

SuZhou-Joe commented Aug 2, 2023 • edited Loading

Description

Issues Resolved

Screenshot

Testing the changes

Check List

codecov-commenter commented Aug 2, 2023 • edited Loading

Codecov Report

ruanyl Aug 9, 2023

Choose a reason for hiding this comment

SuZhou-Joe commented Aug 2, 2023 •

edited

Loading

codecov-commenter commented Aug 2, 2023 •

edited

Loading