Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove template section in workspace creation/update page #73

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

raintygao
Copy link
Collaborator

Description

Remove template section in workspace creation/update page

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: tygao <tygao@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Merging #73 (b611065) into workspace (8bacb1b) will increase coverage by 0.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           workspace      #73      +/-   ##
=============================================
+ Coverage      65.70%   65.71%   +0.01%     
=============================================
  Files           3342     3341       -1     
  Lines          64533    64532       -1     
  Branches       10255    10255              
=============================================
+ Hits           42404    42410       +6     
+ Misses         19597    19564      -33     
- Partials        2532     2558      +26     
Flag Coverage Δ
Linux_1 34.67% <ø> (?)
Linux_3 42.58% <ø> (+<0.01%) ⬆️
Windows_1 34.68% <ø> (-0.01%) ⬇️
Windows_2 54.47% <ø> (-0.01%) ⬇️
Windows_3 42.58% <ø> (-0.01%) ⬇️
Windows_4 34.73% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/plugins/dashboard/public/plugin.tsx 0.00% <ø> (ø)
src/plugins/discover/public/plugin.ts 1.86% <ø> (ø)

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@raintygao raintygao merged commit 9bf4ffd into ruanyl:workspace Aug 4, 2023
45 of 48 checks passed
SuZhou-Joe pushed a commit that referenced this pull request Aug 31, 2023
Signed-off-by: tygao <tygao@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 31, 2023
Signed-off-by: tygao <tygao@amazon.com>
ruanyl pushed a commit that referenced this pull request Sep 15, 2023
Signed-off-by: tygao <tygao@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants