-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration ACL check with saved objects. #74
Integration ACL check with saved objects. #74
Conversation
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
dae1644
to
2fdd9b7
Compare
Codecov Report
@@ Coverage Diff @@
## workspace #74 +/- ##
==============================================
- Coverage 65.71% 42.43% -23.29%
==============================================
Files 3341 1604 -1737
Lines 64532 32489 -32043
Branches 10255 6085 -4170
==============================================
- Hits 42410 13787 -28623
+ Misses 19593 17659 -1934
+ Partials 2529 1043 -1486
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2287 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
src/core/server/workspaces/saved_objects/workspace_saved_objects_client_wrapper.ts
Show resolved
Hide resolved
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
* feat: enable find with acl permission check Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add public Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: enable name change Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: make test run Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some optimization on authentication part Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize authentication Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
* feat: enable find with acl permission check Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add public Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: enable name change Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: make test run Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some optimization on authentication part Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize authentication Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
* feat: enable find with acl permission check Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add public Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: enable name change Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: make test run Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some optimization on authentication part Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize authentication Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr