Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration ACL check with saved objects. #74

Conversation

SuZhou-Joe
Copy link
Collaborator

@SuZhou-Joe SuZhou-Joe commented Aug 4, 2023

Description

  1. Make saved objects search under ACL DSL control.
  2. Implement permission_service.

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe force-pushed the feature/permission_control_service_implementation branch from dae1644 to 2fdd9b7 Compare August 4, 2023 04:33
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Merging #74 (479dcb3) into workspace (9bf4ffd) will decrease coverage by 23.29%.
The diff coverage is 0.00%.

❗ Current head 479dcb3 differs from pull request most recent head f61ffb1. Consider uploading reports for the commit f61ffb1 to get more accurate results

@@              Coverage Diff               @@
##           workspace      #74       +/-   ##
==============================================
- Coverage      65.71%   42.43%   -23.29%     
==============================================
  Files           3341     1604     -1737     
  Lines          64532    32489    -32043     
  Branches       10255     6085     -4170     
==============================================
- Hits           42410    13787    -28623     
+ Misses         19593    17659     -1934     
+ Partials        2529     1043     -1486     
Flag Coverage Δ
Linux_1 ?
Linux_3 42.43% <0.00%> (-0.16%) ⬇️
Windows_1 ?
Windows_2 ?
Windows_3 ?
Windows_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../core/public/saved_objects/saved_objects_client.ts 4.85% <ø> (-84.47%) ⬇️
...ore/server/saved_objects/permission_control/acl.ts 4.76% <0.00%> (-60.72%) ⬇️
...er/saved_objects/permission_control/client.mock.ts 100.00% <ø> (ø)
.../server/saved_objects/permission_control/client.ts 0.00% <0.00%> (-7.70%) ⬇️
...core/server/saved_objects/saved_objects_service.ts 0.00% <0.00%> (-86.49%) ⬇️
...ore/server/saved_objects/service/lib/repository.ts 1.38% <0.00%> (-82.81%) ⬇️
...ved_objects/service/lib/search_dsl/query_params.ts 5.15% <0.00%> (-78.55%) ⬇️
...saved_objects/service/lib/search_dsl/search_dsl.ts 0.00% <ø> (-100.00%) ⬇️
..._objects/workspace_saved_objects_client_wrapper.ts 4.00% <0.00%> (-2.16%) ⬇️

... and 2287 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe merged commit 5a12d0b into ruanyl:workspace Aug 7, 2023
37 of 39 checks passed
SuZhou-Joe added a commit that referenced this pull request Aug 31, 2023
* feat: enable find with acl permission check

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: bootstrap error

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add public

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: enable name change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: make test run

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: some optimization

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: some optimization on authentication part

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimize authentication

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe added a commit that referenced this pull request Aug 31, 2023
* feat: enable find with acl permission check

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: bootstrap error

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add public

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: enable name change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: make test run

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: some optimization

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: some optimization on authentication part

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimize authentication

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
ruanyl pushed a commit that referenced this pull request Sep 15, 2023
* feat: enable find with acl permission check

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: bootstrap error

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add public

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: enable name change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: make test run

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: some optimization

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: some optimization on authentication part

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimize authentication

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants