Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write permisions outside instead of workspace attributes #79

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Aug 9, 2023

Description

Move permissions attribute outside instead on in workspace attributes

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Lin Wang <wonglam@amazon.com>
@wanglam wanglam marked this pull request as ready for review August 9, 2023 02:59
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Merging #79 (d03934c) into workspace (e14f696) will decrease coverage by 0.01%.
The diff coverage is 25.00%.

@@              Coverage Diff              @@
##           workspace      #79      +/-   ##
=============================================
- Coverage      65.66%   65.66%   -0.01%     
=============================================
  Files           3341     3341              
  Lines          64591    64599       +8     
  Branches       10271    10277       +6     
=============================================
+ Hits           42414    42416       +2     
- Misses         19618    19620       +2     
- Partials        2559     2563       +4     
Flag Coverage Δ
Linux_1 34.67% <ø> (ø)
Linux_3 42.41% <0.00%> (-0.01%) ⬇️
Windows_1 34.68% <ø> (ø)
Windows_2 54.35% <25.00%> (-0.02%) ⬇️
Windows_3 42.41% <0.00%> (-0.02%) ⬇️
Windows_4 34.60% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/core/public/workspace/workspaces_client.ts 14.86% <ø> (ø)
...rver/saved_objects/service/saved_objects_client.ts 57.69% <ø> (ø)
src/core/server/workspaces/workspaces_client.ts 9.67% <0.00%> (-1.04%) ⬇️
...e/server/saved_objects/serialization/serializer.ts 90.00% <33.33%> (-4.74%) ⬇️
...ore/server/saved_objects/service/lib/repository.ts 83.69% <40.00%> (-0.50%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wanglam wanglam merged commit 06e37a3 into ruanyl:workspace Aug 9, 2023
44 of 50 checks passed
SuZhou-Joe pushed a commit that referenced this pull request Aug 31, 2023
Signed-off-by: Lin Wang <wonglam@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 31, 2023
Signed-off-by: Lin Wang <wonglam@amazon.com>
ruanyl pushed a commit that referenced this pull request Sep 15, 2023
Signed-off-by: Lin Wang <wonglam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants