Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: call saved objects with internal user #80

Merged

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Aug 10, 2023

Description

Call saved objects API with internal user

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@wanglam wanglam marked this pull request as ready for review August 10, 2023 03:15
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #80 (c5f197b) into workspace (166c06d) will decrease coverage by 0.04%.
Report is 3 commits behind head on workspace.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           workspace      #80      +/-   ##
=============================================
- Coverage      65.84%   65.80%   -0.04%     
=============================================
  Files           3333     3333              
  Lines          64344    64392      +48     
  Branches       10232    10248      +16     
=============================================
+ Hits           42365    42374       +9     
- Misses         19445    19451       +6     
- Partials        2534     2567      +33     
Flag Coverage Δ
Linux_1 34.73% <ø> (-0.01%) ⬇️
Linux_3 42.71% <ø> (ø)
Windows_1 34.75% <ø> (-0.01%) ⬇️
Windows_2 54.72% <ø> (ø)
Windows_3 42.71% <ø> (ø)
Windows_4 34.79% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Lin Wang <wonglam@amazon.com>
@wanglam wanglam force-pushed the feat-call-saved-objects-with-internal-user branch from e830036 to c5f197b Compare August 11, 2023 08:15
@wanglam wanglam merged commit 9393525 into ruanyl:workspace Aug 15, 2023
44 of 49 checks passed
SuZhou-Joe pushed a commit that referenced this pull request Aug 31, 2023
Signed-off-by: Lin Wang <wonglam@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 31, 2023
Signed-off-by: Lin Wang <wonglam@amazon.com>
ruanyl pushed a commit that referenced this pull request Sep 15, 2023
Signed-off-by: Lin Wang <wonglam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants