add permission check when updating workspace #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuZhou-Joe
reviewed
Aug 10, 2023
src/core/server/workspaces/saved_objects/workspace_saved_objects_client_wrapper.ts
Outdated
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Aug 10, 2023
src/core/server/workspaces/saved_objects/workspace_saved_objects_client_wrapper.ts
Outdated
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Aug 10, 2023
src/core/server/workspaces/saved_objects/workspace_saved_objects_client_wrapper.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## workspace #81 +/- ##
=============================================
- Coverage 65.65% 60.49% -5.16%
=============================================
Files 3341 2904 -437
Lines 64594 56767 -7827
Branches 10276 9092 -1184
=============================================
- Hits 42411 34344 -8067
- Misses 19620 20409 +789
+ Partials 2563 2014 -549
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 700 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
raintygao
force-pushed
the
feat-workspace-permission
branch
from
6df8edb
to
0a5053c
Compare
SuZhou-Joe
approved these changes
Aug 11, 2023
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 31, 2023
* feat: add permission check when updating workspace Signed-off-by: tygao <tygao@amazon.com> * fix: only use management access and update bulkUpdate logic Signed-off-by: tygao <tygao@amazon.com> * chore: update code Signed-off-by: tygao <tygao@amazon.com> * chore: update code after rebase Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 31, 2023
* feat: add permission check when updating workspace Signed-off-by: tygao <tygao@amazon.com> * fix: only use management access and update bulkUpdate logic Signed-off-by: tygao <tygao@amazon.com> * chore: update code Signed-off-by: tygao <tygao@amazon.com> * chore: update code after rebase Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com>
ruanyl
pushed a commit
that referenced
this pull request
Sep 15, 2023
* feat: add permission check when updating workspace Signed-off-by: tygao <tygao@amazon.com> * fix: only use management access and update bulkUpdate logic Signed-off-by: tygao <tygao@amazon.com> * chore: update code Signed-off-by: tygao <tygao@amazon.com> * chore: update code after rebase Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add permission check when updating workspace
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr