Delete saved object when deleting workspace #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Codecov Report
@@ Coverage Diff @@
## workspace #84 +/- ##
=============================================
- Coverage 65.75% 60.66% -5.10%
=============================================
Files 3336 2898 -438
Lines 64555 56652 -7903
Branches 10292 9084 -1208
=============================================
- Hits 42450 34366 -8084
- Misses 19523 20290 +767
+ Partials 2582 1996 -586
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 705 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
ruanyl
reviewed
Aug 22, 2023
| * entirely. This method and [`addToWorkspaces`]{@link SavedObjectsRepository.addToWorkspaces} are the only ways to change which workspace a | ||
| * saved object is shared to. | ||
| */ | ||
| async deleteFromWorkspaces( |
There was a problem hiding this comment.
It looks this function has not yet used, I guess we should always call this function when deleting object within a workspace, am I right?
There was a problem hiding this comment.
It's not used for now. when we should call this function that depends on the UX flow of share. The delete method is used for all saved objects deletion and should works well before share is implemented.
ruanyl
approved these changes
Aug 22, 2023
…e_from_workspace Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
force-pushed
the
feature/delete_from_workspace
branch
from
9a578e4
to
24c2f91
Compare
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
opensearch-workspace-development bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
* remove objects from workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * delete saved object when deleting workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix osd bootstrap issue Signed-off-by: Hailong Cui <ihailong@amazon.com> * add force option to delete saved objects when deleting workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove force delete option Signed-off-by: Hailong Cui <ihailong@amazon.com> * redirect only delete workspace successfuly Signed-off-by: Hailong Cui <ihailong@amazon.com> * delete saved object when deleting workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * delete saved object when deleting workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * Add more unit test cases Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit f465403) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am
pushed a commit
that referenced
this pull request
Sep 13, 2023
* remove objects from workspace * delete saved object when deleting workspace * fix osd bootstrap issue * add force option to delete saved objects when deleting workspace * remove force delete option * redirect only delete workspace successfuly * delete saved object when deleting workspace * delete saved object when deleting workspace * Add more unit test cases --------- (cherry picked from commit f465403) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Sep 15, 2023
* remove objects from workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * delete saved object when deleting workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix osd bootstrap issue Signed-off-by: Hailong Cui <ihailong@amazon.com> * add force option to delete saved objects when deleting workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove force delete option Signed-off-by: Hailong Cui <ihailong@amazon.com> * redirect only delete workspace successfuly Signed-off-by: Hailong Cui <ihailong@amazon.com> * delete saved object when deleting workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * delete saved object when deleting workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * Add more unit test cases Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 16, 2023
* remove objects from workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * delete saved object when deleting workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix osd bootstrap issue Signed-off-by: Hailong Cui <ihailong@amazon.com> * add force option to delete saved objects when deleting workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove force delete option Signed-off-by: Hailong Cui <ihailong@amazon.com> * redirect only delete workspace successfuly Signed-off-by: Hailong Cui <ihailong@amazon.com> * delete saved object when deleting workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * delete saved object when deleting workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * Add more unit test cases Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr