fix: redirect to home only when delete and exit workspace successfully #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuZhou-Joe
reviewed
Aug 17, 2023
| @@ -127,16 +137,6 @@ export const WorkspaceUpdater = () => { | |||
| } | |||
| } | |||
| setDeleteWorkspaceModalVisible(false); | |||
There was a problem hiding this comment.
This line should be moved into if clause I think.
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
SuZhou-Joe
approved these changes
Aug 17, 2023
ruanyl
approved these changes
Aug 17, 2023
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 31, 2023
#89) * only navigate to home page when delete and exit workspace successfully Signed-off-by: yuye-aws <yuyezhu@amazon.com> * unsubscribe workspaceEnabled when workspace service stop Signed-off-by: yuye-aws <yuyezhu@amazon.com> * only hide delete modal when delete workspace successfully Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 31, 2023
#89) * only navigate to home page when delete and exit workspace successfully Signed-off-by: yuye-aws <yuyezhu@amazon.com> * unsubscribe workspaceEnabled when workspace service stop Signed-off-by: yuye-aws <yuyezhu@amazon.com> * only hide delete modal when delete workspace successfully Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com>
ruanyl
pushed a commit
that referenced
this pull request
Sep 15, 2023
#89) * only navigate to home page when delete and exit workspace successfully Signed-off-by: yuye-aws <yuyezhu@amazon.com> * unsubscribe workspaceEnabled when workspace service stop Signed-off-by: yuye-aws <yuyezhu@amazon.com> * only hide delete modal when delete workspace successfully Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A navigation bug for delete and exit workspace has been fixed in this PR. With this PR, the user will only navigation to home page when delete and exit workspace successfully. Also, I also fixed a bug for workspace start. The value of
workspaceEnabled$will unsubscribe whenWorkspaceServiceget stopped.Issues Resolved
Screenshot
The error message remains the same:
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr